Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2244 ic date input improve deletion of full date via keyboard #3239

Merged
merged 2 commits into from
Feb 24, 2025
Merged

2244 ic date input improve deletion of full date via keyboard #3239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9042b4
feat(canary-web-components): add the ability to backspace through a d…
GCHQ-Developer-530 Feb 21, 2025
534252c
feat(canary-react): add the ability to backspace through a date input…
GCHQ-Developer-530 Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/canary-react/src/component-tests/IcDateInput/IcDateInput.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,30 @@ describe("IcDateInput end-to-end, visual regression and a11y tests", () => {
cy.findShadowEl(DATE_INPUT, YEAR_INPUT_ARIA_LABEL).should(HAVE_VALUE, "");
});

it("should test deleting the date using backspace", () => {
mount(<IcDateInput label="Test Label" />);

cy.checkHydrated(DATE_INPUT);

cy.findShadowEl(DATE_INPUT, DAY_INPUT_ARIA_LABEL).type("30");
cy.findShadowEl(DATE_INPUT, MONTH_INPUT_ARIA_LABEL).type("04");
cy.findShadowEl(DATE_INPUT, YEAR_INPUT_ARIA_LABEL).type("2000");

cy.findShadowEl(DATE_INPUT, YEAR_INPUT_ARIA_LABEL).type(
"{Backspace}{Backspace}{Backspace}{Backspace}"
);
cy.findShadowEl(DATE_INPUT, MONTH_INPUT_ARIA_LABEL).type(
"{Backspace}{Backspace}"
);
cy.findShadowEl(DATE_INPUT, DAY_INPUT_ARIA_LABEL).type(
"{Backspace}{Backspace}"
);

cy.findShadowEl(DATE_INPUT, DAY_INPUT_ARIA_LABEL).should(HAVE_VALUE, "");
cy.findShadowEl(DATE_INPUT, MONTH_INPUT_ARIA_LABEL).should(HAVE_VALUE, "");
cy.findShadowEl(DATE_INPUT, YEAR_INPUT_ARIA_LABEL).should(HAVE_VALUE, "");
});

it("should enter complete date and check for accessibility", () => {
mount(
<div style={{ padding: "10px" }}>
Expand Down
6 changes: 6 additions & 0 deletions packages/canary-web-components/src/components/ic-date-input/ic-date-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,6 +600,12 @@ export class DateInput {
this.preventAutoFormatting = true;
this.handleUpDownArrowKeyPress(input, event);
break;
case "backspace":
if (input.value.length === 0) {
event.preventDefault();
this.moveToPreviousInput(input);
}
break;
default:
break;
}
Expand Down
Loading