2913 focused toggle button inner border #3243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update audit dates for March
chore(root): update audit dates - v3 cherry pick
…rectly in nav group fix: selected items with hover state are properly lined up within nav group menu
Update docs.json with empty state theme prop
Update empty state to have theme prop to make use of light/dark theme
Readme cherry pick
Update tree view to prevent FOUC - set tree items visibility to hidden until loaded when inherited props from tree view used. Removed timeouts on truncation - tree view now truncates when ready rather than waiting 0.1 seconds to help reduce flashing.
…d items Update tree view truncation story to have expanded items - to show truncation working on nesting items.
Update data table empty state cypress image
Update empty state to have theme prop to make use of light/dark theme
Empty state theme prop
fix(canary-web-components): update tree view to improve FOUC
deployments to npm now run from a dedicated release branch, once complete, are then merged into develop, then main. This prevents any conflicts or needing to merge main back into develop. 2765
…ide nav item when dark Fix double focus indicator on side nav item (light theme colour / dark foreground) when it is selected and a slotted link is used.
Cherry pick up deployment changes
…ator-v3 fix(web-components): fix double focus indicator on selected slotted s…
…ix storybook example Update visual regression images in IcAlert and IcTheme, fix storybook example after height change fix in ic-alert
…themes variables added to variables.css, container min-height now changes on theme change to compensate for border in dark mode
uncommenting out auto dismiss toast accessibility check
…ark-mode fix(web-components): [ic-alert] extra height in DM bug
…to-dismiss toast adding description to ic-loading-indicator of auto-dismiss toast to prevent aria-label a11y failure
…e set programmatically Provide a selectedItemsPerPage prop fix #2525
…grammatically Provide a selectedItemsPerPage prop
changed auto-dismiss toasts from role=status to alert, so they read to screenreaders Made the auto-dismiss toasts polite so they don't interrupt navigation 2710
update the message of the Auto-dismiss toast react story to be more clear about functionality 2710
Update docs.json with disableAutoSort prop on data table
Implement disableAutoSort prop on data table so that the sort button appears and emits a sort event but doesn't actually sort the data . #2415
Cherry pick 2415 v3
[V3 Cherry Pick] tweaks to pkg json (#3168)
Update to Storybook v8 - .stories.mdx replaced with new format of .stories.js and .mdx
description change to say defult button will not be shown however, slotted controls will
Update to storybook v8 - with new format for stories
…g-controls-are-displayed-regardless-of-buttons-prop docs(web-components): description change in the buttons prop
adds workflow to trigger v3 guidance site update
cherry-pick trigger of v3 site check-versions
Upgrade storybook v3
replace references to regular develop with v3 develop
replace references to release with v3.0.0/release in the v3 release check script
Fix v3 release workflow cherrypick
- @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected]
fixes build by committing files which have changed
delete development release check file to unblock release
- @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected]
updating inner border of focused toggle button
…e button adding visual regression test for focused, checked toggle button with dark theme
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/2913-focused-toggle-button-inner-border/web-components |
MI6-255
force-pushed
the
v3.0.0/develop
branch
2 times, most recently
from
46015cc to
7cab72a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Updated the inner border of focused, checked toggle button so that it is black in dark mode, and added a visual regression test for this scenario.
Related issue
#2913
Checklist
General
Testing
Accessibility