increasing code cov

Author: michaeldcanady

credential_authorization_provider_adapter_test.go

@@ -1,11 +1,52 @@
 package servicenowsdkgo
 
-import "testing"
+import (
+	"errors"
+	"testing"
+
+	"github.com/michaeldcanady/servicenow-sdk-go/internal/mocking"
+	"github.com/stretchr/testify/assert"
+)
 
 func TestNewCredentialAuthenticationProviderAdapter(t *testing.T) {
-	// TODO: add tests
+	tests := []struct {
+		name string
+		test func(*testing.T)
+	}{
+		{
+			name: "successful",
+			test: func(t *testing.T) {
+				cred := mocking.NewMockCredential()
+
+				authenticationProvider, err := newCredentialAuthenticationProviderAdapter(cred)
+				assert.Nil(t, err)
+				assert.Equal(t, &credentialAuthenticationProviderAdapter{
+					cred: cred,
+				}, authenticationProvider)
+			},
+		},
+		{
+			name: "nil credential",
+			test: func(t *testing.T) {
+				authenticationProvider, err := newCredentialAuthenticationProviderAdapter(nil)
+				assert.Equal(t, errors.New("credential is nil"), err)
+				assert.Nil(t, authenticationProvider)
+			},
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, test.test)
+	}
 }
 
 func TestCredentialAuthenticationProviderAdapter_AuthenticateRequest(t *testing.T) {
-	// TODO: add tests
+	tests := []struct {
+		name string
+		test func(*testing.T)
+	}{}
+
+	for _, test := range tests {
+		t.Run(test.name, test.test)
+	}
 }

internal/mocking/mock_context.go

@@ -0,0 +1,37 @@
+package mocking
+
+import (
+	"time"
+
+	"github.com/stretchr/testify/mock"
+)
+
+type MockContext struct {
+	mock.Mock
+}
+
+func NewMockContext() *MockContext {
+	return &MockContext{
+		mock.Mock{},
+	}
+}
+
+func (c *MockContext) Deadline() (deadline time.Time, ok bool) {
+	_ = c.Called(deadline, ok)
+	return
+}
+
+func (c *MockContext) Done() <-chan struct{} {
+	args := c.Called()
+	return args.Get(0).(<-chan struct{})
+}
+
+func (c *MockContext) Err() error {
+	args := c.Called()
+	return args.Error(0)
+}
+
+func (c *MockContext) Value(key any) any {
+	args := c.Called(key)
+	return args.Get(0)
+}

internal/mocking/mock_credential.go

@@ -0,0 +1,18 @@
+package mocking
+
+import "github.com/stretchr/testify/mock"
+
+type MockCredential struct {
+	mock.Mock
+}
+
+func NewMockCredential() *MockCredential {
+	return &MockCredential{
+		mock.Mock{},
+	}
+}
+
+func (c *MockCredential) GetAuthentication() (string, error) {
+	args := c.Called()
+	return args.String(0), args.Error(1)
+}

internal/mocking/mock_option.go

@@ -0,0 +1,18 @@
+package mocking
+
+import "github.com/stretchr/testify/mock"
+
+type MockOption[T any] struct {
+	mock.Mock
+}
+
+func NewMockOption[T any]() *MockOption[T] {
+	return &MockOption[T]{
+		mock.Mock{},
+	}
+}
+
+func (o *MockOption[T]) Option(config T) error {
+	args := o.Called(config)
+	return args.Error(0)
+}

internal/new/servicenow_request_adapter.go

@@ -26,6 +26,7 @@ func NewServiceNowRequestAdapter(authenticationProvider authentication.Authentic
 
 	baseAdapter, err := nethttplibrary.NewNetHttpRequestAdapterWithParseNodeFactoryAndSerializationWriterFactoryAndHttpClient(authenticationProvider, config.parseNodeFactory, config.serializationWriterFactory, config.client)
 	if err != nil {
+		// can't test
 		return nil, err
 	}
 	return &ServiceNowRequestAdapter{baseAdapter}, nil

internal/new/servicenow_request_adapter_test.go

@@ -1,9 +1,50 @@
 package internal
 
 import (
+	"errors"
 	"testing"
+
+	"github.com/michaeldcanady/servicenow-sdk-go/internal/mocking"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/mock"
 )
 
 func TestNewServiceNowRequestAdapter(t *testing.T) {
-	// TODO: add tests
+	tests := []struct {
+		name string
+		test func(*testing.T)
+	}{
+		{
+			name: "successful",
+			test: func(t *testing.T) {
+				authProvider := mocking.NewMockAuthenticationProvider()
+
+				_, err := NewServiceNowRequestAdapter(authProvider)
+				assert.Nil(t, err)
+			},
+		},
+		{
+			name: "nil AuthenticationProvider",
+			test: func(t *testing.T) {
+				_, err := NewServiceNowRequestAdapter(nil)
+				assert.Equal(t, errors.New("authenticationProvider cannot be nil"), err)
+			},
+		},
+		{
+			name: "successful",
+			test: func(t *testing.T) {
+				authProvider := mocking.NewMockAuthenticationProvider()
+				strct := mocking.NewMockOption[*serviceNowRequestAdapterConfig]()
+				strct.On("Option", mock.IsType(&serviceNowRequestAdapterConfig{})).Return(errors.New("opt error"))
+				opt := strct.Option
+
+				_, err := NewServiceNowRequestAdapter(authProvider, opt)
+				assert.Equal(t, errors.New("opt error"), err)
+			},
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, test.test)
+	}
 }

servicenow_service_client_config_test.go

@@ -37,6 +37,14 @@ func TestBuildServiceClientConfig(t *testing.T) {
 				assert.Nil(t, config)
 			},
 		},
+		{
+			name: "instance and raw uri",
+			test: func(t *testing.T) {
+				config, err := buildServiceClientConfig(withInstance("fdasfsda"), withURL("https://dafsfd.com"))
+				assert.Equal(t, errors.New("rawURL and instance cannot be used together"), err)
+				assert.Nil(t, config)
+			},
+		},
 	}
 
 	for _, test := range tests {