length-of does not work for vectors

[spiffytech]

cms.validation=> ((vr/length-of :stuff :is 5) {:stuff [1 2 3 4 5]})

ClassCastException clojure.lang.PersistentVector cannot be cast to java.lang.CharSequence  clojure.string/blank? (string.clj:291)

I see you're using count under the hood, so length-of should be adaptable? In any case, it would sure be great to have a vector length validation function in Validateur.

[michaelklishin]

@spiffytech feel free to submit a PR for that. We'd have two cases: strings (char sequences) and collections. Those can use different core functions.

[michalmarczyk]

The problem here is that

1. length-of includes a nil check and a blank string check using not-allowed-to-be-blank? under the hood;
2. not-allowed-to-be-blank? blindly applies string/blank? to its input, whether it is a string or not;
3. this cannot even be overridden with allow-blank true, because not-allowed-to-be-blank? checks allowed-blank last, so it always makes the string/blank? call, even if unnecessary;
4. this same check is then repeated (with inverted Boolean logic, but same end effect) in equal-length-of and range-length-of, so it'd also need to be fixed there.

The main size/length/count check would indeed accept anything that count knows how to handle, including vectors.