Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Customization Options for Icons and Formatting #68

Open
chacha912 opened this issue Mar 11, 2025 · 2 comments · May be fixed by #69
Open

Additional Customization Options for Icons and Formatting #68

chacha912 opened this issue Mar 11, 2025 · 2 comments · May be fixed by #69

Comments

@chacha912
Copy link

chacha912 commented Mar 11, 2025 •
edited
Loading

First, I'd like to thank you for maintaining react-json-view. It's an excellent library that I've been using extensively in my projects!

I've made some custom modifications to meet specific UI requirements:

  1. Added an iconStyle='arrow' option to change the default triangle icons to arrows
  2. Implemented a displayBraceColon={false} prop to hide the colon after braces

Image

My Questions

  • Are there existing, documented ways to achieve these customizations that I might have missed?
  • If not, would you consider these features as potential additions to the library?

I'd be happy to contribute a PR for these features if you think they would be valuable additions to the library.
I share the commits where I implemented these customizations for your reference. chacha912/react-json-view@a06cb3e

Thank you for considering my request!
@chacha912 chacha912 mentioned this issue Mar 11, 2025
Merged
2 tasks
@pgliang001
Copy link

pgliang001 commented Mar 15, 2025 •
edited
Loading

Hi @chacha912

In recommend, rename displayBraceColon to displayCompact. This better illustrates the output visual effect rather than the behavior. Naming displayCompact mean to do more than hide the colon after braces if you or other can in future.

PS. i borrow the naming from gmail setting ^_^

@chacha912
Copy link
Author

@pgliang001 Thanks for the good suggestion. I'll make the changes and submit a PR.

@chacha912 chacha912 linked a pull request Mar 16, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add displayCompact options and new icon styles chacha912/react-json-view1
2 participants
@pgliang001 @chacha912