Skip to content

Commit 4b8d1c5

Browse files
authored
Increase snapshotRefreshTimeoutMs for non local drivers on e2e tests (#22871)
Refresh snapshot lifecycle tests are having timeout issues while running them against FRS and ODSP drivers. On debugging I was able to detect a throttling error while requesting updating the snapshot since the timeout to request a new snapshot was too short. On increasing such timeout to 1sec instead of 100ms, the throttling error disappear completely on local tests while running against ODSP without impacting on test duration (this could be subject to further calibration). My hypothesis is that while running on the lab, snapshot refresh fails silently, and given we never refreshed, our deferred promises that awaits for it never resolves, ending in the timeout.
1 parent 7405cf5 commit 4b8d1c5

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

packages/test/test-end-to-end-tests/src/test/refreshSerializerLifeCycle.spec.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,13 @@ describeCompat("Refresh snapshot lifecycle", "NoCompat", (getTestObjectProvider,
162162
) {
163163
return;
164164
}
165+
let snapshotRefreshTimeoutMs;
166+
if (
167+
testConfig.timeoutRefreshInOriginalContainer ||
168+
testConfig.timeoutRefreshInLoadedContainer
169+
) {
170+
snapshotRefreshTimeoutMs = provider.driver.type === "local" ? 100 : 1000;
171+
}
165172
const getLatestSnapshotInfoP = new Deferred<void>();
166173
const testContainerConfig = {
167174
fluidDataObjectType: DataObjectFactoryType.Test,
@@ -186,11 +193,7 @@ describeCompat("Refresh snapshot lifecycle", "NoCompat", (getTestObjectProvider,
186193
"Fluid.Container.enableOfflineSnapshotRefresh": true,
187194
"Fluid.Container.UseLoadingGroupIdForSnapshotFetch":
188195
testConfig.useLoadingGroupIdForSnapshotFetch,
189-
"Fluid.Container.snapshotRefreshTimeoutMs":
190-
testConfig.timeoutRefreshInOriginalContainer ||
191-
testConfig.timeoutRefreshInLoadedContainer
192-
? 100
193-
: undefined,
196+
"Fluid.Container.snapshotRefreshTimeoutMs": snapshotRefreshTimeoutMs,
194197
}),
195198
},
196199
};

0 commit comments

Comments
 (0)