refactor(container-runtime): Enable @typescript-eslint/no-unsafe-argument eslint rule and fix violations (#23697)

Part of a multi-PR process to migrate this package off of our deprecated
"minimal" eslint config to our "recommended" one.


[AB#3027](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/3027)

Author: Josmithr

packages/runtime/container-runtime/.eslintrc.cjs

@@ -42,6 +42,7 @@ module.exports = {
 				ignoreRestArgs: true,
 			},
 		],
+		"@typescript-eslint/no-unsafe-argument": "error",
 		"@typescript-eslint/no-unsafe-assignment": "error",
 		"@typescript-eslint/no-unsafe-call": "error",
 		"@typescript-eslint/no-unsafe-member-access": "error",

packages/runtime/container-runtime/src/containerRuntime.ts

@@ -38,6 +38,7 @@ import {
 	ITelemetryBaseLogger,
 } from "@fluidframework/core-interfaces";
 import {
+	type IErrorBase,
 	IFluidHandleContext,
 	type IFluidHandleInternal,
 	IProvideFluidHandleContext,
@@ -804,15 +805,14 @@ async function createSummarizer(loader: ILoader, url: string): Promise<ISummariz
 	// Older containers may not have the "getEntryPoint" API
 	// ! This check will need to stay until LTS of loader moves past 2.0.0-internal.7.0.0
 	if (resolvedContainer.getEntryPoint === undefined) {
-		// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-assignment
-		const response = await (resolvedContainer as any).request({
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-explicit-any
+		const response = (await (resolvedContainer as any).request({
 			url: `/${summarizerRequestUrl}`,
-		});
-		// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+		})) as IResponse;
 		if (response.status !== 200 || response.mimeType !== "fluid/object") {
 			throw responseToException(response, request);
 		}
-		// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-assignment
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 		fluidObject = response.value;
 	} else {
 		fluidObject = await resolvedContainer.getEntryPoint();
@@ -1236,7 +1236,7 @@ export class ContainerRuntime
 					runtime.setConnectionStateCore(true, runtime.delayConnectClientId);
 				}
 			},
-			(error) => runtime.closeFn(error),
+			(error: IErrorBase) => runtime.closeFn(error),
 		);
 
 		// Apply stashed ops with a reference sequence number equal to the sequence number of the snapshot,
@@ -2120,7 +2120,7 @@ export class ContainerRuntime
 					"summarizerStart",
 					"summarizerStartupFailed",
 				]) {
-					this.summaryManager?.on(eventName, (...args: any[]) => {
+					this.summaryManager?.on(eventName, (...args: unknown[]) => {
 						this.emit(eventName, ...args);
 					});
 				}

packages/runtime/container-runtime/src/gc/gcConfigs.ts

@@ -104,7 +104,9 @@ export function generateGCConfigs(
 	// Note that if no generation option is provided, Sweep is allowed for any document.
 	const sweepAllowed = shouldAllowGcSweep(
 		persistedGcFeatureMatrix ?? {} /* featureMatrix */,
-		createParams.gcOptions[gcGenerationOptionName] /* currentGeneration */,
+		createParams.gcOptions[gcGenerationOptionName] as
+			| number
+			| undefined /* currentGeneration */,
 	);
 
 	/**

packages/runtime/container-runtime/src/summary/runningSummarizer.ts

@@ -196,7 +196,10 @@ export class RunningSummarizer
 	private totalSuccessfulAttempts = 0;
 	private initialized = false;
 
-	private readonly runtimeListener;
+	private readonly runtimeListener: (
+		op: ISequencedDocumentMessage,
+		runtimeMessage?: boolean,
+	) => void;
 
 	/**
 	 * The maximum number of summary attempts to do when submit summary fails.
@@ -956,7 +959,7 @@ export class RunningSummarizer
 		const { reason, ...summarizeOptions } = options;
 		if (options.retryOnFailure === true) {
 			this.summarizeOnDemandWithRetries(`onDemand;${reason}`, resultsBuilder).catch(
-				(error) => {
+				(error: IRetriableFailureError) => {
 					resultsBuilder.fail("summarize failed", error);
 				},
 			);

packages/runtime/container-runtime/src/summary/summarizer.ts

@@ -39,6 +39,7 @@ import {
 	// eslint-disable-next-line import/no-deprecated
 	ISummarizerRuntime,
 	ISummarizingWarning,
+	type IRetriableFailureError,
 } from "./summarizerTypes.js";
 import { SummaryCollection } from "./summaryCollection.js";
 import { SummarizeResultBuilder } from "./summaryGenerator.js";
@@ -369,11 +370,11 @@ export class Summarizer extends TypedEventEmitter<ISummarizerEvents> implements
 							runCoordinator.stop(stopReason);
 							this.close();
 						})
-						.catch((error) => {
+						.catch((error: IRetriableFailureError) => {
 							builder.fail("Failed to start summarizer", error);
 						});
 				})
-				.catch((error) => {
+				.catch((error: IRetriableFailureError) => {
 					builder.fail("Failed to create cancellation token", error);
 				});
 
@@ -402,11 +403,11 @@ export class Summarizer extends TypedEventEmitter<ISummarizerEvents> implements
 
 	private setupForwardedEvents(): void {
 		for (const event of ["summarize", "summarizeAllAttemptsFailed"]) {
-			const listener = (...args: any[]): void => {
+			const listener = (...args: unknown[]): void => {
 				this.emit(event, ...args);
 			};
 			// TODO: better typing here
-			// eslint-disable-next-line @typescript-eslint/no-explicit-any
+			// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-argument
 			this.runningSummarizer?.on(event as any, listener);
 			this.forwardedEvents.set(event, listener);
 		}

packages/runtime/container-runtime/src/summary/summarizerNode/summarizerNodeWithGc.ts

@@ -427,7 +427,7 @@ export class SummarizerNodeWithGC extends SummarizerNode implements IRootSummari
 			const pendingSummaryWithGC = pendingSummary as PendingSummaryInfoWithGC;
 			if (pendingSummaryWithGC.serializedUsedRoutes !== undefined) {
 				const childNodeUsedRoutes = unpackChildNodesUsedRoutes(
-					JSON.parse(pendingSummaryWithGC.serializedUsedRoutes),
+					JSON.parse(pendingSummaryWithGC.serializedUsedRoutes) as string[],
 				);
 				const newSerializedRoutes = childNodeUsedRoutes.get(id) ?? [""];
 				const childPendingSummaryInfo = {

packages/runtime/container-runtime/src/summary/summaryGenerator.ts

@@ -242,11 +242,13 @@ export class SummaryGenerator {
 		summaryOptions: ISubmitSummaryOptions,
 		resultsBuilder = new SummarizeResultBuilder(),
 	): ISummarizeResults {
-		this.summarizeCore(summaryOptions, resultsBuilder).catch((error) => {
-			const message = "UnexpectedSummarizeError";
-			summaryOptions.summaryLogger.sendErrorEvent({ eventName: message }, error);
-			resultsBuilder.fail(message, error);
-		});
+		this.summarizeCore(summaryOptions, resultsBuilder).catch(
+			(error: IRetriableFailureError) => {
+				const message = "UnexpectedSummarizeError";
+				summaryOptions.summaryLogger.sendErrorEvent({ eventName: message }, error);
+				resultsBuilder.fail(message, error);
+			},
+		);
 
 		return resultsBuilder.build();
 	}

packages/runtime/container-runtime/src/summary/summaryManager.ts

@@ -408,7 +408,7 @@ export class SummaryManager
 		}
 
 		if (delayMs > 0) {
-			let timer;
+			let timer: number | undefined;
 			let resolveOpPromiseFn: (value: void | PromiseLike<void>) => void;
 			// Create a listener that will break the delay if we've exceeded the initial delay ops count.
 			const opsListenerFn = (): void => {
@@ -466,19 +466,19 @@ export class SummaryManager
 			"summarizerStart",
 			"summarizerStartupFailed",
 		]) {
-			const listener = (...args: any[]): void => {
+			const listener = (...args: unknown[]): void => {
 				this.emit(event, ...args);
 			};
 			// TODO: better typing here
-			// eslint-disable-next-line @typescript-eslint/no-explicit-any
+			// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-argument
 			this.summarizer?.on(event as any, listener);
 			this.forwardedEvents.set(event, listener);
 		}
 	}
 
 	private cleanupForwardedEvents(): void {
 		for (const [event, listener] of this.forwardedEvents.entries()) {
-			// eslint-disable-next-line @typescript-eslint/no-explicit-any
+			// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-argument
 			this.summarizer?.off(event as any, listener);
 		}
 		this.forwardedEvents.clear();

packages/runtime/container-runtime/src/test/blobManager.spec.ts

@@ -121,7 +121,7 @@ export class MockRuntime
 
 	public getStorage(): IDocumentStorageService {
 		return {
-			createBlob: async (blob) => {
+			createBlob: async (blob: ArrayBufferLike) => {
 				if (this.processing) {
 					return this.storage.createBlob(blob);
 				}
@@ -139,7 +139,7 @@ export class MockRuntime
 				this.blobPs.push(P);
 				return P;
 			},
-			readBlob: async (id) => this.storage.readBlob(id),
+			readBlob: async (id: string) => this.storage.readBlob(id),
 		} as unknown as IDocumentStorageService;
 	}
 
@@ -234,7 +234,7 @@ export class MockRuntime
 		redirectTable: [string, string][] | undefined;
 	}> {
 		if (this.detachedStorage.blobs.size > 0) {
-			const table = new Map();
+			const table = new Map<string, string>();
 			for (const [detachedId, blob] of this.detachedStorage.blobs) {
 				const { id } = await this.attachedStorage.createBlob(blob);
 				table.set(detachedId, id);
@@ -259,7 +259,7 @@ export class MockRuntime
 		for (const op of ops) {
 			// TODO: better typing
 			// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access
-			this.blobManager.reSubmit((op as any).metadata);
+			this.blobManager.reSubmit((op as any).metadata as Record<string, unknown> | undefined);
 		}
 	}
 
@@ -319,7 +319,11 @@ export const validateSummary = (
 			assert.strictEqual(key, redirectTableBlobName);
 			assert(attachment.type === SummaryType.Blob);
 			assert(typeof attachment.content === "string");
-			redirectTable = [...new Map<string, string>(JSON.parse(attachment.content)).entries()];
+			redirectTable = [
+				...new Map<string, string>(
+					JSON.parse(attachment.content) as [string, string][],
+				).entries(),
+			];
 		}
 	}
 	return { ids, redirectTable };
@@ -869,7 +873,7 @@ describe("BlobManager", () => {
 			await runtime.attach();
 			await runtime.connect();
 			const ac = new AbortController();
-			let handleP;
+			let handleP: Promise<IFluidHandleInternal<ArrayBufferLike>> | undefined;
 			try {
 				const blob = IsoBuffer.from("blob", "utf8");
 				handleP = runtime.createBlob(blob, ac.signal);
@@ -922,7 +926,7 @@ describe("BlobManager", () => {
 			await runtime.attach();
 			await runtime.connect();
 			const ac = new AbortController();
-			let handleP;
+			let handleP: Promise<IFluidHandleInternal<ArrayBufferLike>> | undefined;
 			try {
 				handleP = runtime.createBlob(IsoBuffer.from("blob", "utf8"), ac.signal);
 				const p1 = runtime.processBlobs(true);
@@ -945,7 +949,9 @@ describe("BlobManager", () => {
 			}
 			await runtime.connect();
 			runtime.processOps();
-			await assert.rejects(handleP);
+
+			// TODO: `handleP` can be `undefined`; this should be made safer.
+			await assert.rejects(handleP as Promise<IFluidHandleInternal<ArrayBufferLike>>);
 			const summaryData = validateSummary(runtime);
 			assert.strictEqual(summaryData.ids.length, 0);
 			assert.strictEqual(summaryData.redirectTable, undefined);

packages/runtime/container-runtime/src/test/containerRuntime.spec.ts

@@ -425,13 +425,17 @@ describe("Runtime", () => {
 
 					if (enableOfflineLoad) {
 						assert(
-							// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-							batchIdMatchesUnsentFormat(submittedOps[0].metadata?.batchId),
+							batchIdMatchesUnsentFormat(
+								// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+								submittedOps[0].metadata?.batchId as string | undefined,
+							),
 							"expected unsent batchId format (0)",
 						);
 						assert(
-							// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-							batchIdMatchesUnsentFormat(submittedOps[1].metadata?.batchId),
+							batchIdMatchesUnsentFormat(
+								// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+								submittedOps[1].metadata?.batchId as string | undefined,
+							),
 							"expected unsent batchId format (0)",
 						);
 					} else {
@@ -1700,9 +1704,9 @@ describe("Runtime", () => {
 			it("summary fails after generate if there are pending ops", async () => {
 				// Patch the summarize function to submit messages during it. This way there will be pending
 				// messages after generating the summary.
-				const patch = (fn: (...args) => Promise<ISummaryTreeWithStats>) => {
+				const patch = (fn: (...args: any[]) => Promise<ISummaryTreeWithStats>) => {
 					const boundFn = fn.bind(containerRuntime);
-					return async (...args: any[]) => {
+					return async (...args: unknown[]) => {
 						// Submit an op and yield for it to be flushed from outbox to pending state manager.
 						submitDataStoreOp(containerRuntime, "fakeId", "fakeContents");
 						await yieldEventLoop();
@@ -2312,7 +2316,7 @@ describe("Runtime", () => {
 								JSON.stringify(
 									'{"gcNodes":{"/":{"outboundRoutes":["/rootDOId"]},"/rootDOId":{"outboundRoutes":["/rootDOId/de68ca53-be31-479e-8d34-a267958997e4","/rootDOId/root"]},"/rootDOId/de68ca53-be31-479e-8d34-a267958997e4":{"outboundRoutes":["/rootDOId"]},"/rootDOId/root":{"outboundRoutes":["/rootDOId","/rootDOId/de68ca53-be31-479e-8d34-a267958997e4"]}}}',
 								),
-							),
+							) as string,
 							"utf8",
 						),
 					],

packages/runtime/container-runtime/src/test/opLifecycle/duplicateBatchDetector.spec.ts

@@ -146,7 +146,9 @@ describe("DuplicateBatchDetector", () => {
 		detector.processInboundBatch(inboundBatch1);
 
 		const summaryPayload = JSON.stringify(detector.getRecentBatchInfoForSummary());
-		const detector2 = new DuplicateBatchDetector(JSON.parse(summaryPayload));
+		const detector2 = new DuplicateBatchDetector(
+			JSON.parse(summaryPayload) as [number, string][] | undefined,
+		);
 
 		const inboundBatch2 = makeBatch({
 			sequenceNumber: seqNum++, // 2

packages/runtime/container-runtime/src/test/summary/runningSummarizer.spec.ts

@@ -1164,7 +1164,7 @@ describe("Runtime", () => {
 						"should be nack",
 					);
 					assert(
-						// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access
+						// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
 						JSON.parse((ackNackResult.data.summaryNackOp as any).data).message === "test-nack",
 						"summary nack error should be test-nack",
 					);