build(fetch-tool): use node16 module resolution (#20240)

Semi-automatic PR to switch to node16 module resolution

---------

Co-authored-by: Sonali Deshpande <[email protected]>

Author: DLehenbauer

packages/tools/fetch-tool/package.json

@@ -10,26 +10,25 @@
 	},
 	"license": "MIT",
 	"author": "Microsoft and contributors",
-	"main": "dist/fluidFetch.js",
-	"types": "dist/fluidFetch.d.ts",
+	"type": "module",
 	"bin": {
 		"fluid-fetch": "bin/fluid-fetch"
 	},
 	"scripts": {
 		"build": "fluid-build . --task build",
 		"build:compile": "fluid-build . --task compile",
-		"check:are-the-types-wrong": "attw --pack",
+		"build:esnext": "tsc --project ./tsconfig.json",
 		"check:biome": "biome check .",
 		"check:prettier": "prettier --check . --cache --ignore-path ../../../.prettierignore",
-		"clean": "rimraf --glob dist \"**/*.tsbuildinfo\" \"**/*.build.log\"",
+		"clean": "rimraf --glob dist \"**/*.tsbuildinfo\" \"**/*.build.log\" lib",
 		"eslint": "eslint --format stylish src",
 		"eslint:fix": "eslint --format stylish src --fix --fix-type problem,suggestion,layout",
 		"format": "fluid-build --task format .",
 		"format:biome": "biome check --apply .",
 		"format:prettier": "prettier --write . --cache --ignore-path ../../../.prettierignore",
 		"lint": "fluid-build . --task lint",
 		"lint:fix": "fluid-build . --task eslint:fix --task format",
-		"tsc": "tsc"
+		"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist"
 	},
 	"dependencies": {
 		"@fluid-internal/client-utils": "workspace:~",
@@ -49,14 +48,14 @@
 		"@fluidframework/tool-utils": "workspace:~"
 	},
 	"devDependencies": {
-		"@arethetypeswrong/cli": "^0.13.3",
 		"@biomejs/biome": "^1.6.1",
 		"@fluid-tools/build-cli": "^0.34.0",
 		"@fluid-tools/fetch-tool-previous": "npm:@fluid-tools/[email protected]",
 		"@fluidframework/build-common": "^2.0.3",
 		"@fluidframework/build-tools": "^0.34.0",
 		"@fluidframework/eslint-config-fluid": "^5.1.0",
 		"@types/node": "^18.19.0",
+		"copyfiles": "^2.4.1",
 		"eslint": "~8.55.0",
 		"prettier": "~3.0.3",
 		"rimraf": "^4.4.0",

packages/tools/fetch-tool/src/fluidFetch.ts

@@ -6,11 +6,11 @@
 import fs from "fs";
 import util from "util";
 import { IOdspDriveItem, isOdspHostname } from "@fluidframework/odsp-doclib-utils/internal";
-import { paramSaveDir, paramURL, parseArguments } from "./fluidFetchArgs";
-import { connectionInfo, fluidFetchInit } from "./fluidFetchInit";
-import { fluidFetchMessages } from "./fluidFetchMessages";
-import { getSharepointFiles, getSingleSharePointFile } from "./fluidFetchSharePoint";
-import { fluidFetchSnapshot } from "./fluidFetchSnapshot";
+import { paramSaveDir, paramURL, parseArguments } from "./fluidFetchArgs.js";
+import { connectionInfo, fluidFetchInit } from "./fluidFetchInit.js";
+import { fluidFetchMessages } from "./fluidFetchMessages.js";
+import { getSharepointFiles, getSingleSharePointFile } from "./fluidFetchSharePoint.js";
+import { fluidFetchSnapshot } from "./fluidFetchSnapshot.js";
 
 async function fluidFetchOneFile(urlStr: string, name?: string) {
 	const documentService = await fluidFetchInit(urlStr);

packages/tools/fetch-tool/src/fluidFetchInit.ts

@@ -15,8 +15,8 @@ import { FluidAppOdspUrlResolver, OdspUrlResolver } from "@fluidframework/odsp-u
 import * as r11s from "@fluidframework/routerlicious-driver";
 import { RouterliciousUrlResolver } from "@fluidframework/routerlicious-urlresolver";
 import { getMicrosoftConfiguration } from "@fluidframework/tool-utils";
-import { localDataOnly, paramJWT } from "./fluidFetchArgs";
-import { resolveWrapper } from "./fluidFetchSharePoint";
+import { localDataOnly, paramJWT } from "./fluidFetchArgs.js";
+import { resolveWrapper } from "./fluidFetchSharePoint.js";
 
 export let latestVersionsId: string = "";
 export let connectionInfo: any;

packages/tools/fetch-tool/src/fluidFetchMessages.ts

@@ -12,15 +12,15 @@ import {
 	MessageType,
 	ScopeType,
 } from "@fluidframework/protocol-definitions";
-import { printMessageStats } from "./fluidAnalyzeMessages";
+import { printMessageStats } from "./fluidAnalyzeMessages.js";
 import {
 	connectToWebSocket,
 	dumpMessageStats,
 	dumpMessages,
 	messageTypeFilter,
 	overWrite,
 	paramActualFormatting,
-} from "./fluidFetchArgs";
+} from "./fluidFetchArgs.js";
 
 function filenameFromIndex(index: number): string {
 	return index === 0 ? "" : index.toString(); // support old tools...

packages/tools/fetch-tool/src/fluidFetchSharePoint.ts

@@ -21,7 +21,7 @@ import {
 	getMicrosoftConfiguration,
 	odspTokensCache,
 } from "@fluidframework/tool-utils";
-import { getForceTokenReauth } from "./fluidFetchArgs";
+import { getForceTokenReauth } from "./fluidFetchArgs.js";
 
 export async function resolveWrapper<T>(
 	callback: (authRequestInfo: IOdspAuthRequestInfo) => Promise<T>,

packages/tools/fetch-tool/src/fluidFetchSnapshot.ts

@@ -10,16 +10,16 @@ import { bufferToString, stringToBuffer } from "@fluid-internal/client-utils";
 import { IDocumentService, IDocumentStorageService } from "@fluidframework/driver-definitions";
 import { ISnapshotTree, IVersion } from "@fluidframework/protocol-definitions";
 
-import { formatNumber } from "./fluidAnalyzeMessages";
+import { formatNumber } from "./fluidAnalyzeMessages.js";
 import {
 	dumpSnapshotStats,
 	dumpSnapshotTrees,
 	dumpSnapshotVersions,
 	paramActualFormatting,
 	paramNumSnapshotVersions,
 	paramSnapshotVersionIndex,
-} from "./fluidFetchArgs";
-import { latestVersionsId } from "./fluidFetchInit";
+} from "./fluidFetchArgs.js";
+import { latestVersionsId } from "./fluidFetchInit.js";
 
 interface ISnapshotInfo {
 	blobCountNew: number;

packages/tools/fetch-tool/tsconfig.cjs.json

@@ -0,0 +1,7 @@
+{
+	// This config must be used in a "type": "commonjs" environment. (Use `fluid-tsc commonjs`.)
+	"extends": "./tsconfig.json",
+	"compilerOptions": {
+		"outDir": "./dist",
+	},
+}

packages/tools/fetch-tool/tsconfig.json

@@ -1,13 +1,10 @@
 {
-	"extends": [
-		"../../../common/build/build-common/tsconfig.base.json",
-		"../../../common/build/build-common/tsconfig.cjs.json",
-	],
+	"extends": "../../../common/build/build-common/tsconfig.node16.json",
 	"include": ["src/**/*.ts"],
 	"exclude": ["dist", "node_modules"],
 	"compilerOptions": {
 		"rootDir": "./src",
-		"outDir": "./dist",
+		"outDir": "./lib",
 		"types": ["node"],
 	},
 }