build: Use strict eslint config in common/definitions packages (#18982)

Updates several common packages to use the strict eslint config,
primarily so type-only exports/imports are enforced.

Author: tylerbutler

packages/common/container-definitions/.eslintrc.cjs

@@ -4,12 +4,15 @@
  */
 
 module.exports = {
-	extends: [require.resolve("@fluidframework/eslint-config-fluid/recommended"), "prettier"],
+	extends: [require.resolve("@fluidframework/eslint-config-fluid/strict"), "prettier"],
 	plugins: ["deprecation"],
 	parserOptions: {
 		project: ["./tsconfig.json", "./src/test/types/tsconfig.json"],
 	},
 	rules: {
+		// TODO: Enabling this may require breaking changes.
+		"@typescript-eslint/consistent-indexed-object-style": "off",
+
 		// This library is used in the browser, so we don't want dependencies on most node libraries.
 		"import/no-nodejs-modules": ["error", { allow: ["events"] }],
 	},

packages/common/container-definitions/api-report/container-definitions.api.md

@@ -4,36 +4,36 @@
 
 ```ts
 
-import { EventEmitter } from 'events';
-import { FluidObject } from '@fluidframework/core-interfaces';
-import { IAnyDriverError } from '@fluidframework/driver-definitions';
-import { IClient } from '@fluidframework/protocol-definitions';
-import { IClientConfiguration } from '@fluidframework/protocol-definitions';
-import { IClientDetails } from '@fluidframework/protocol-definitions';
-import { IDisposable } from '@fluidframework/core-interfaces';
-import { IDocumentMessage } from '@fluidframework/protocol-definitions';
-import { IDocumentStorageService } from '@fluidframework/driver-definitions';
+import type { EventEmitter } from 'events';
+import type { FluidObject } from '@fluidframework/core-interfaces';
+import type { IAnyDriverError } from '@fluidframework/driver-definitions';
+import type { IClient } from '@fluidframework/protocol-definitions';
+import type { IClientConfiguration } from '@fluidframework/protocol-definitions';
+import type { IClientDetails } from '@fluidframework/protocol-definitions';
+import type { IDisposable } from '@fluidframework/core-interfaces';
+import type { IDocumentMessage } from '@fluidframework/protocol-definitions';
+import type { IDocumentStorageService } from '@fluidframework/driver-definitions';
 import { IErrorBase } from '@fluidframework/core-interfaces';
-import { IErrorEvent } from '@fluidframework/core-interfaces';
-import { IEvent } from '@fluidframework/core-interfaces';
-import { IEventProvider } from '@fluidframework/core-interfaces';
+import type { IErrorEvent } from '@fluidframework/core-interfaces';
+import type { IEvent } from '@fluidframework/core-interfaces';
+import type { IEventProvider } from '@fluidframework/core-interfaces';
 import { IGenericError } from '@fluidframework/core-interfaces';
-import { IQuorumClients } from '@fluidframework/protocol-definitions';
-import { IRequest } from '@fluidframework/core-interfaces';
-import { IResolvedUrl } from '@fluidframework/driver-definitions';
-import { ISequencedDocumentMessage } from '@fluidframework/protocol-definitions';
-import { ISequencedProposal } from '@fluidframework/protocol-definitions';
-import { ISignalMessage } from '@fluidframework/protocol-definitions';
-import { ISnapshot } from '@fluidframework/driver-definitions';
-import { ISnapshotTree } from '@fluidframework/protocol-definitions';
-import { ISummaryContent } from '@fluidframework/protocol-definitions';
-import { ISummaryTree } from '@fluidframework/protocol-definitions';
-import { ITelemetryBaseLogger } from '@fluidframework/core-interfaces';
+import type { IQuorumClients } from '@fluidframework/protocol-definitions';
+import type { IRequest } from '@fluidframework/core-interfaces';
+import type { IResolvedUrl } from '@fluidframework/driver-definitions';
+import type { ISequencedDocumentMessage } from '@fluidframework/protocol-definitions';
+import type { ISequencedProposal } from '@fluidframework/protocol-definitions';
+import type { ISignalMessage } from '@fluidframework/protocol-definitions';
+import type { ISnapshot } from '@fluidframework/driver-definitions';
+import type { ISnapshotTree } from '@fluidframework/protocol-definitions';
+import type { ISummaryContent } from '@fluidframework/protocol-definitions';
+import type { ISummaryTree } from '@fluidframework/protocol-definitions';
+import type { ITelemetryBaseLogger } from '@fluidframework/core-interfaces';
 import { IThrottlingWarning } from '@fluidframework/core-interfaces';
-import { ITokenClaims } from '@fluidframework/protocol-definitions';
+import type { ITokenClaims } from '@fluidframework/protocol-definitions';
 import { IUsageError } from '@fluidframework/core-interfaces';
-import { IVersion } from '@fluidframework/protocol-definitions';
-import { MessageType } from '@fluidframework/protocol-definitions';
+import type { IVersion } from '@fluidframework/protocol-definitions';
+import type { MessageType } from '@fluidframework/protocol-definitions';
 
 // @public
 export enum AttachState {

packages/common/container-definitions/src/audience.ts

@@ -5,8 +5,8 @@
 
 // False positive: this is an import from the `events` package, not from Node.
 // eslint-disable-next-line unicorn/prefer-node-protocol
-import { EventEmitter } from "events";
-import { IClient } from "@fluidframework/protocol-definitions";
+import type { EventEmitter } from "events";
+import type { IClient } from "@fluidframework/protocol-definitions";
 
 /**
  * Manages the state and the members for {@link IAudience}

packages/common/container-definitions/src/browserPackage.ts

@@ -3,7 +3,8 @@
  * Licensed under the MIT License.
  */
 
-import { IFluidPackage, isFluidPackage, IFluidPackageEnvironment } from "./fluidPackage";
+import type { IFluidPackage, IFluidPackageEnvironment } from "./fluidPackage";
+import { isFluidPackage } from "./fluidPackage";
 
 /**
  * A specific Fluid package environment for browsers

packages/common/container-definitions/src/deltas.ts

@@ -3,15 +3,15 @@
  * Licensed under the MIT License.
  */
 
-import {
+import type {
 	IDisposable,
 	IEventProvider,
 	IEvent,
 	IErrorEvent,
 	IErrorBase,
 } from "@fluidframework/core-interfaces";
-import { IAnyDriverError } from "@fluidframework/driver-definitions";
-import {
+import type { IAnyDriverError } from "@fluidframework/driver-definitions";
+import type {
 	IClientConfiguration,
 	IClientDetails,
 	IDocumentMessage,

packages/common/container-definitions/src/error.ts

@@ -3,7 +3,8 @@
  * Licensed under the MIT License.
  */
 
-import { FluidErrorTypes, IErrorBase } from "@fluidframework/core-interfaces";
+import type { IErrorBase } from "@fluidframework/core-interfaces";
+import { FluidErrorTypes } from "@fluidframework/core-interfaces";
 
 /**
  * Different error types the ClientSession may report out to the Host.

packages/common/container-definitions/src/fluidModule.ts

@@ -3,9 +3,9 @@
  * Licensed under the MIT License.
  */
 
-import { FluidObject } from "@fluidframework/core-interfaces";
-import { IProvideFluidCodeDetailsComparer } from "./fluidPackage";
-import { IRuntimeFactory } from "./runtime";
+import type { FluidObject } from "@fluidframework/core-interfaces";
+import type { IProvideFluidCodeDetailsComparer } from "./fluidPackage";
+import type { IRuntimeFactory } from "./runtime";
 
 /**
  * @alpha

packages/common/container-definitions/src/index.ts

@@ -9,13 +9,10 @@
  * @packageDocumentation
  */
 
-export { IAudience, IAudienceOwner } from "./audience";
-export {
-	IFluidBrowserPackage,
-	IFluidBrowserPackageEnvironment,
-	isFluidBrowserPackage,
-} from "./browserPackage";
-export {
+export type { IAudience, IAudienceOwner } from "./audience";
+export type { IFluidBrowserPackage, IFluidBrowserPackageEnvironment } from "./browserPackage";
+export { isFluidBrowserPackage } from "./browserPackage";
+export type {
 	IConnectionDetails,
 	IDeltaManager,
 	IDeltaManagerEvents,
@@ -24,8 +21,9 @@ export {
 	IDeltaSender,
 	ReadOnlyInfo,
 } from "./deltas";
-export { ContainerErrorTypes, ContainerWarning, ICriticalContainerError } from "./error";
-export {
+export type { ContainerWarning, ICriticalContainerError } from "./error";
+export { ContainerErrorTypes } from "./error";
+export type {
 	ConnectionState,
 	ICodeDetailsLoader,
 	IContainer,
@@ -40,30 +38,27 @@ export {
 	IProvideLoader,
 	IResolvedFluidCodeDetails,
 	ISnapshotTreeWithBlobContents,
-	LoaderHeader,
 } from "./loader";
-export { IFluidModule } from "./fluidModule";
-export {
+export { LoaderHeader } from "./loader";
+export type { IFluidModule } from "./fluidModule";
+export type {
 	IFluidPackage,
 	IFluidPackageEnvironment,
 	IFluidCodeDetails,
-	IFluidCodeDetailsComparer,
 	IFluidCodeDetailsConfig,
 	IProvideFluidCodeDetailsComparer,
-	isFluidPackage,
-	isFluidCodeDetails,
 } from "./fluidPackage";
-export {
-	AttachState,
+export { IFluidCodeDetailsComparer, isFluidPackage, isFluidCodeDetails } from "./fluidPackage";
+export type {
 	IBatchMessage,
 	IContainerContext,
 	IProvideRuntimeFactory,
 	IRuntime,
-	IRuntimeFactory,
 	IGetPendingLocalStateProps,
 } from "./runtime";
+export { AttachState, IRuntimeFactory } from "./runtime";
 
-export {
+export type {
 	/**
 	 * @deprecated IErrorBase is being deprecated as a public export is moving to "core-interfaces".
 	 */

packages/common/container-definitions/src/loader.ts

@@ -3,8 +3,13 @@
  * Licensed under the MIT License.
  */
 
-import { IRequest, FluidObject, IEvent, IEventProvider } from "@fluidframework/core-interfaces";
-import {
+import type {
+	IRequest,
+	FluidObject,
+	IEvent,
+	IEventProvider,
+} from "@fluidframework/core-interfaces";
+import type {
 	IClient,
 	IClientDetails,
 	IDocumentMessage,
@@ -13,13 +18,17 @@ import {
 	ISequencedProposal,
 	ISnapshotTree,
 } from "@fluidframework/protocol-definitions";
-import { IResolvedUrl } from "@fluidframework/driver-definitions";
-import { IAudience } from "./audience";
-import { IDeltaManager, ReadOnlyInfo } from "./deltas";
-import { ICriticalContainerError, ContainerWarning } from "./error";
-import { IFluidModule } from "./fluidModule";
-import { AttachState } from "./runtime";
-import { IFluidCodeDetails, IFluidPackage, IProvideFluidCodeDetailsComparer } from "./fluidPackage";
+import type { IResolvedUrl } from "@fluidframework/driver-definitions";
+import type { IAudience } from "./audience";
+import type { IDeltaManager, ReadOnlyInfo } from "./deltas";
+import type { ICriticalContainerError, ContainerWarning } from "./error";
+import type { IFluidModule } from "./fluidModule";
+import type { AttachState } from "./runtime";
+import type {
+	IFluidCodeDetails,
+	IFluidPackage,
+	IProvideFluidCodeDetailsComparer,
+} from "./fluidPackage";
 
 /**
  * Encapsulates a module entry point with corresponding code details.

packages/common/container-definitions/src/runtime.ts

@@ -3,10 +3,14 @@
  * Licensed under the MIT License.
  */
 
-import { ITelemetryBaseLogger, IDisposable, FluidObject } from "@fluidframework/core-interfaces";
+import type {
+	ITelemetryBaseLogger,
+	IDisposable,
+	FluidObject,
+} from "@fluidframework/core-interfaces";
 
-import { IDocumentStorageService, ISnapshot } from "@fluidframework/driver-definitions";
-import {
+import type { IDocumentStorageService, ISnapshot } from "@fluidframework/driver-definitions";
+import type {
 	IClientDetails,
 	ISequencedDocumentMessage,
 	ISnapshotTree,
@@ -17,11 +21,11 @@ import {
 	IQuorumClients,
 	ISummaryContent,
 } from "@fluidframework/protocol-definitions";
-import { IAudience } from "./audience";
-import { IDeltaManager } from "./deltas";
-import { ICriticalContainerError } from "./error";
-import { ILoader } from "./loader";
-import { IFluidCodeDetails } from "./fluidPackage";
+import type { IAudience } from "./audience";
+import type { IDeltaManager } from "./deltas";
+import type { ICriticalContainerError } from "./error";
+import type { ILoader } from "./loader";
+import type { IFluidCodeDetails } from "./fluidPackage";
 
 /**
  * The attachment state of some Fluid data (e.g. a container or data store), denoting whether it is uploaded to the

packages/common/core-interfaces/.eslintrc.cjs

@@ -4,8 +4,12 @@
  */
 
 module.exports = {
-	extends: [require.resolve("@fluidframework/eslint-config-fluid"), "prettier"],
+	extends: [require.resolve("@fluidframework/eslint-config-fluid/strict"), "prettier"],
 	parserOptions: {
 		project: ["./tsconfig.json", "./src/test/tsconfig.json"],
 	},
+	rules: {
+		// TODO: Enabling this may require breaking changes.
+		"@typescript-eslint/consistent-indexed-object-style": "off",
+	},
 };

packages/common/core-interfaces/src/error.ts

@@ -3,7 +3,7 @@
  * Licensed under the MIT License.
  */
 
-import { ITelemetryBaseProperties } from "./index";
+import type { ITelemetryBaseProperties } from "./index";
 
 /**
  * Error types the Fluid Framework may report.

packages/common/core-interfaces/src/fluidLoadable.ts

@@ -3,7 +3,7 @@
  * Licensed under the MIT License.
  */
 
-import { IFluidHandle } from "./handles";
+import type { IFluidHandle } from "./handles";
 
 /**
  * @public

packages/common/core-interfaces/src/handles.ts

@@ -3,9 +3,9 @@
  * Licensed under the MIT License.
  */
 
-import { IRequest, IResponse } from "./fluidRouter";
-import { IFluidLoadable } from "./fluidLoadable";
-import { FluidObject } from "./provider";
+import type { IRequest, IResponse } from "./fluidRouter";
+import type { IFluidLoadable } from "./fluidLoadable";
+import type { FluidObject } from "./provider";
 
 /**
  * @public