Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Use environment markers in setup.py #237

Open
ianlini opened this issue Aug 20, 2019 · 1 comment · May be fixed by #238
Open

Use environment markers in setup.py #237

ianlini opened this issue Aug 20, 2019 · 1 comment · May be fixed by #238

Comments

@ianlini
Copy link

ianlini commented Aug 20, 2019

Describe the bug
Using sys.version_info to modify dependencies is not a recommended way according to
python-poetry/poetry#758. We should use environment markers instead. If we use sys.version_info to modify dependencies, some package managers such as Poetry will fail to get the correct dependencies.

To Reproduce
Steps to reproduce the behavior:

  1. install poetry
  2. in a Python 3.7.4 environment, poetry add nimbusml
  3. poetry will try to install enum (0.4.7), which is a dependency for Python 2
  4. the installation will fail (I think enum only support Python 2)

Expected behavior
The installation succeed without installing those dependencies for Python 2.

Additional context
The Python package Ray also had the same issue. We can refer to their PR ray-project/ray#3764.

@ianlini
Copy link
Author

ianlini commented Sep 23, 2020

I can use poetry to install nimbusml 1.8.0 now, but the PR is not merged and sys.version_info is still used.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant