Merge pull request #31 from microsoft/eleretzk/fulltext/plumb-limit

Plumb limit to full text search function

Author: eliranek1

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@microsoft/objectstoreprovider",
-  "version": "0.6.35",
+  "version": "0.6.36",
   "description": "A cross-browser object store library",
   "author": "Mukundan Kavanur Kidambi <[email protected]>",
   "scripts": {

src/ObjectStoreProvider.ts

@@ -397,11 +397,11 @@ export abstract class DbProvider {
     indexName: string,
     searchPhrase: string,
     resolution: FullTextTermResolution = FullTextTermResolution.And,
-    _limit?: number
+    limit?: number
   ): Promise<ItemType[]> {
     return this._getStoreIndexTransaction(storeName, false, indexName).then(
       (index) => {
-        return index.fullTextSearch(searchPhrase, resolution);
+        return index.fullTextSearch(searchPhrase, resolution, limit);
       }
     );
   }

src/tests/ObjectStoreProvider.spec.ts

@@ -4519,7 +4519,7 @@ describe("ObjectStoreProvider", function () {
         });
       }
 
-      it("Full Text Index", (done) => {
+      it("Full Text Index - Happy path", (done) => {
         openProvider(
           provName,
           {
@@ -4879,6 +4879,82 @@ describe("ObjectStoreProvider", function () {
             (err) => done(err)
           );
       });
+
+      it("Full Text Index - Returns only the limit passed for OR resolution", async () => {
+        return openProvider(
+          provName,
+          {
+            version: 2,
+            stores: [
+              {
+                name: "test",
+                primaryKeyPath: "id",
+                indexes: [
+                  {
+                    name: "i",
+                    keyPath: "txt",
+                    fullText: true,
+                    unique: false,
+                  },
+                ],
+              },
+            ],
+          },
+          true
+        ).then((prov) => {
+          const itemsToPut = [];
+          for (var i = 0; i < 100; i++) {
+            itemsToPut.push({ id: `a${i}`, txt: `aaaaaa${i}` });
+          }
+
+          prov.put("test", itemsToPut).then(() => {
+            prov
+              .fullTextSearch("test", "i", "a", FullTextTermResolution.Or, 10)
+              .then((results) => {
+                assert.equal(results.length, 10);
+                prov.close();
+              });
+          });
+        });
+      });
+
+      it("Full Text Index - Returns only the limit passed for AND resolution", async () => {
+        return openProvider(
+          provName,
+          {
+            version: 2,
+            stores: [
+              {
+                name: "test",
+                primaryKeyPath: "id",
+                indexes: [
+                  {
+                    name: "i",
+                    keyPath: "txt",
+                    fullText: true,
+                    unique: false,
+                  },
+                ],
+              },
+            ],
+          },
+          true
+        ).then((prov) => {
+          const itemsToPut = [];
+          for (var i = 0; i < 100; i++) {
+            itemsToPut.push({ id: `a${i}`, txt: `aaaaaa${i}` });
+          }
+
+          prov.put("test", itemsToPut).then(() => {
+            prov
+              .fullTextSearch("test", "i", "a", FullTextTermResolution.And, 10)
+              .then((results) => {
+                assert.equal(results.length, 10);
+                prov.close();
+              });
+          });
+        });
+      });
     });
   });
 });