Apply suggestions from code review - directly index splited result as there will be always a result

dldl-cmd · baywet · web-flow · commit 012440bd148c · 2025-02-06T19:39:04.000+01:00
Co-authored-by: Vincent Biret &lt;vincentbiret@hotmail.com&gt;
diff --git a/src/Microsoft.OpenApi/Reader/V3/OpenApiV3Deserializer.cs b/src/Microsoft.OpenApi/Reader/V3/OpenApiV3Deserializer.cs
@@ -196,7 +196,7 @@ private static (string, string) GetReferenceIdAndExternalResource(string pointer
             string externalResource = null;
             if (isExternalResource)
             {
-                externalResource = pointer.Split('#').FirstOrDefault()?.TrimEnd('#');
+                externalResource = pointer.Split('#')[0].TrimEnd('#');
             }
 
             return (refId, externalResource);
diff --git a/src/Microsoft.OpenApi/Reader/V31/OpenApiV31Deserializer.cs b/src/Microsoft.OpenApi/Reader/V31/OpenApiV31Deserializer.cs
@@ -165,7 +165,7 @@ private static (string, string) GetReferenceIdAndExternalResource(string pointer
             string externalResource = null;
             if (isExternalResource && pointer.Contains('#'))
             {
-                externalResource = pointer.Split('#').FirstOrDefault()?.TrimEnd('#');
+                externalResource = pointer.Split('#')[0].TrimEnd('#');
             }
 
             return (refId, externalResource);

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ private static (string, string) GetReferenceIdAndExternalResource(string pointer`
`196`	`196`	`string externalResource = null;`
`197`	`197`	`if (isExternalResource)`
`198`	`198`	`{`
`199`		`- externalResource = pointer.Split('#').FirstOrDefault()?.TrimEnd('#');`
	`199`	`+ externalResource = pointer.Split('#')[0].TrimEnd('#');`
`200`	`200`	`}`
`201`	`201`
`202`	`202`	`return (refId, externalResource);`
Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ private static (string, string) GetReferenceIdAndExternalResource(string pointer`
`165`	`165`	`string externalResource = null;`
`166`	`166`	`if (isExternalResource && pointer.Contains('#'))`
`167`	`167`	`{`
`168`		`- externalResource = pointer.Split('#').FirstOrDefault()?.TrimEnd('#');`
	`168`	`+ externalResource = pointer.Split('#')[0].TrimEnd('#');`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`return (refId, externalResource);`