Skip to content

Position of nullable property changed in output document #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bkoelman opened this issue Apr 30, 2025 · 2 comments · Fixed by #2358
Closed

Position of nullable property changed in output document #2344

bkoelman opened this issue Apr 30, 2025 · 2 comments · Fixed by #2358
Assignees
Labels
help wanted priority:p3 Nice to have. Customer impact is very minimal type:enhancement Enhancement request targeting an existing experience
Milestone

Comments

@bkoelman
Copy link
Contributor

Please restore the position of the nullable property in the output document. Comparing 2.0 preview with 1.x stable, it has moved:

Image

While technically the position shouldn't matter, this difference makes it a pain to assess whether the preview version produces a similar output document in our test suite. We have about 12,000 tests, many of which compare fragments of the OAS file, failing on changes like this.

@baywet baywet added this to the 2.1 milestone May 16, 2025
@baywet baywet added type:enhancement Enhancement request targeting an existing experience help wanted priority:p3 Nice to have. Customer impact is very minimal labels May 16, 2025
@baywet
Copy link
Member

baywet commented May 16, 2025

Hi @bkoelman
Thank you for using the SDK and for reaching out.

We chatted about this while reviewing the other issue. While we won't be fixing that before the general availability as we're trying to prioritize the work, we might look at that after.

Is this something you'd like to submit a pull request for provided some guidance?

@bkoelman
Copy link
Contributor Author

PR here: #2358.

@baywet baywet modified the milestones: 2.1, v2-Preview20 May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted priority:p3 Nice to have. Customer impact is very minimal type:enhancement Enhancement request targeting an existing experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants