Auto import does not pick up shortest path despite correct setting (JavaScript project with jsconfig.json)

[rwalle]

Bug Report

🔎 Search Terms

• shortest path
• auto import relative path
• auto import parent folder

I found a few closely related issues, and a few of them are marked as fixed. But since I am using a very recent version of the TS server, I was not expecting the issue to appear in my setup.

• VS Code file rename ignores importModuleSpecifier #25739
• VSCode never offers a (shorter) relative import path when the module matches compilerOptions.paths #26348
• Import module specifier: "shortest" doesn't pre-select the shortest (typescript) #42235
• Auto import of monorepo package not using node_modules specifier #51269

🕗 Version & Regression Information

TS Server 5.0.4 in VSCode 1.78.2

⏯ Playground Link

N/A -- project setup

💻 Code

Please use the code in this repository:

https://github.com/rwalle/ts-path-issue

🙁 Actual behavior

We have a monorepo setup without node_modules, and for simplicity, assume all packages live under the same folder. A team only develops one or a few packages, and they may have dependencies between them. In the example repository, package1 depends on package2. jsconfig.json has been correctly setup.

After opening setup1/package1 as the only workspace folder in VSCode, open file1.js and type bar, the import path is ../package2/file1. The value for VSCode extension setting javascript.preferences.importModuleSpecifier is the default "shortest". If this is changed to "non-relative" or "project-relative", it gets worse -- it becomes package1/../package2/file1.

Alternatively, under "shortest" setting, move file1.js to a subfolder and try to import bar, you always see package1/../package2/file1.

However, if I manually type import { bar } from 'p', it can find package2. Also go to definition works properly if you uncomment the import at the beginning of that file.

After opening setup2 as the workspace folder in VSCode, type bar, import path is package2/file1. However we don't want to do that -- root folder is huge and nobody wants to have all folders and files from irrelevant packages visible in the workspace tree and potentially watched.

🙂 Expected behavior

For setup1/package1, TS Service correctly provides the shortest path package2/file1.

[andrewbranch]

Looks like a duplicate of #53369, which means it was fixed in #53957. Please make sure to try out the nightly TypeScript version before you go through all the trouble of making a repro! Let me know if the nightly doesn’t solve your problem, but I’m going to go ahead and close because it looks identical.

[rwalle]

Looks like a duplicate of #53369, which means it was fixed in #53957. Please make sure to try out the nightly TypeScript version before you go through all the trouble of making a repro! Let me know if the nightly doesn’t solve your problem, but I’m going to go ahead and close because it looks identical.

I just installed typescript@next extension and still seeing the same thing with 5.2.0-dev.20230517, and I think I am using the correct version by checking the command and the TS Server log

Would you mind validating this?

[andrewbranch]

I can’t repro anything like package1/../package2/file1, which I kind of got tunnel vision on in your initial description. I get ../package2/file1. But you want package2/file1.

[rwalle]

I can’t repro anything like package1/../package2/file1, which I kind of got tunnel vision on in your initial description. I get ../package2/file1. But you want package2/file1.

Correct, the behavior has changed but is still not what a user would expect. (I was not clear in the previous comment)

[andrewbranch]

My bad, I was skimming for the most horrifying parts of the actual behavior 😄