Skip to content

Add missing test coverage found in #57909 #57911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
RyanCavanaugh opened this issue Mar 22, 2024 · 2 comments · Fixed by #57917
Closed
1 task done

Add missing test coverage found in #57909 #57911

RyanCavanaugh opened this issue Mar 22, 2024 · 2 comments · Fixed by #57917
Assignees
Labels
Fix Available A PR has been opened for this issue Infrastructure Issue relates to TypeScript team infrastructure

Comments

@RyanCavanaugh
Copy link
Member

Acknowledgement

  • I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion.

Comment

#57909 hit two DT tests and 1 user project but didn't affect any compiler baselines. We need equivalent coverage from those breaks

@RyanCavanaugh RyanCavanaugh added the Infrastructure Issue relates to TypeScript team infrastructure label Mar 22, 2024
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 5.5.0 milestone Mar 22, 2024
@Andarist
Copy link
Contributor

FYI, I'm already in the process of extracting those test cases

@Andarist
Copy link
Contributor

I'm leaving this here for posterity: TS playground. This one has a React-based repro (and its slimmed down version) - I don't want to include the full-blown React repro in the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Available A PR has been opened for this issue Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
4 participants