Merge pull request #1016 from Microsoft/cleanup/rename-internal-configure

Rename internal configure: to configureWith: and remove a // FIXME

Author: iamclement

AppCenter/AppCenter/Internals/MSAppCenterPrivate.h

@@ -19,7 +19,6 @@
  * @discussion This may be called only once per application process lifetime.
  * @param appSecret A unique and secret key used to identify the application.
  */
-// FIXME: Rename to configureWithAppSecret
-- (BOOL)configure:(NSString *)appSecret;
+- (BOOL)configureWithAppSecret:(NSString *)appSecret;
 
 @end

AppCenter/AppCenter/MSAppCenter.m

@@ -59,7 +59,7 @@ + (instancetype)sharedInstance {
 #pragma mark - public
 
 + (void)configureWithAppSecret:(NSString *)appSecret {
-  [[self sharedInstance] configure:appSecret];
+  [[self sharedInstance] configureWithAppSecret:appSecret];
 }
 
 + (void)start:(NSString *)appSecret withServices:(NSArray<Class> *)services {
@@ -192,7 +192,7 @@ - (instancetype)init {
  * Configuring without an app secret is valid. If that is the case, the app secret will
  * not be set.
  */
-- (BOOL)configure:(NSString *)appSecret {
+- (BOOL)configureWithAppSecret:(NSString *)appSecret {
   @synchronized(self) {
     BOOL success = false;
     if (self.sdkConfigured) {
@@ -235,7 +235,7 @@ - (BOOL)configure:(NSString *)appSecret {
 
 - (void)start:(NSString *)appSecret withServices:(NSArray<Class> *)services {
   @synchronized(self) {
-    BOOL configured = [self configure:appSecret];
+    BOOL configured = [self configureWithAppSecret:appSecret];
     if (configured && services) {
       MSLogVerbose([MSAppCenter logTag], @"Prepare to start services: %@", [services componentsJoinedByString:@", "]);
       NSArray *sortedServices = [self sortServices:services];

AppCenter/AppCenterTests/MSAppCenterTests.m

@@ -499,7 +499,7 @@ - (void)testAppIsBackgrounded {
 
   // If
   id<MSChannelGroupProtocol> channelGroup = OCMProtocolMock(@protocol(MSChannelGroupProtocol));
-  [self.sut configure:@"AnAppSecret"];
+  [self.sut configureWithAppSecret:@"AnAppSecret"];
   self.sut.channelGroup = channelGroup;
 
   // When
@@ -513,7 +513,7 @@ - (void)testAppIsForegrounded {
 
   // If
   id<MSChannelGroupProtocol> channelGroup = OCMProtocolMock(@protocol(MSChannelGroupProtocol));
-  [self.sut configure:@"AnAppSecret"];
+  [self.sut configureWithAppSecret:@"AnAppSecret"];
   self.sut.channelGroup = channelGroup;
 
   // When