Add metadata field to basemessage #5372
Conversation
python/packages/autogen-agentchat/src/autogen_agentchat/messages.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5372 +/- ##
==========================================
- Coverage 75.67% 75.66% -0.01%
==========================================
Files 171 171
Lines 10576 10578 +2
==========================================
+ Hits 8003 8004 +1
- Misses 2573 2574 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This kind of generic property bag is somewhat of a dangerous pattern. What is the use case? |
Please read the PR message again. Another use case is extra content to send alongside the message beyond content. Down the line messages should also support attachments like files/videos/... otherwise agentchat will not be very useful. |
|
Yeah true true. I can see it being useful, but I think the important thing is that agentchat itself should not depend on any properties here. It should be an external concern where this is just the place to funnel that info. |
|
another use cases is a hack for passing structured messages through metadata, the agent receiving these messages should have specific logic tuned to accept that in an application. If you have another solution for structured messages, I am happy to use that. Currently, the way to pass structured messages is through json.load and json.dump in content which is ugly |
|
I am wondering here if the desired behavior can be achieved via inheriting message types to add the fields you need? Changing the base message type is a big change we would like to avoid if possible. The way this would work is you inherit from the relevant type and add the fields and when you wnat to read the values you do a type check for the inherited type and cast to get it |
|
I already do this in my application. This PR is so I avoid having the redundant types when merging possibly into agentchat. If you don't this to be merged, that's fine. |
|
I this, for now, those custom types are the right way to go about this. It might change over time but if it's working thats perfect |
|
I agree with all use case that @husseinmozannar mentioned but I also agree with @jackgerrits that interface in agentchat should remain minimal. If an application wants more fields, it should inherit and extend. This is already pretty easy to do for an application. I do not think we should merge this change (at least not right now). |
|
Lets continue talking in #5385 and make sure Hussein has what he needs to make progress @jackgerrits |
|
Thought more about this - I definitely see the utility in this field. And thinking through the alternatives, I do think this makes the most sense. I am a little nervous about misuse, so we as a team should ensure we don't misuse. There are other related features like file/content attachments and structured messages that we need to build to better support scenarios too. I also just want to just get @ekzhu's take before we go ahead too |
|
Comment on #5385 |
|
@ekzhu what would you like to merge this in? |
python/packages/autogen-agentchat/src/autogen_agentchat/messages.py
Outdated
Show resolved
Hide resolved
python/packages/autogen-agentchat/src/autogen_agentchat/messages.py
Outdated
Show resolved
Hide resolved
…es.py Co-authored-by: Eric Zhu <[email protected]>
* doc: Enrich AssistantAgent API documentation with usage examples. (microsoft#5653) Resolves microsoft#5562 * remove dep on aspire - add google.protobuf (microsoft#5645) <!-- Thank you for your contribution! Please review https://microsoft.github.io/autogen/docs/Contribute before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> removes unneeded deps ## Related issue number <!-- For example: "Closes microsoft#1234" --> Closes microsoft#5644 ## Checks - [ ] I've included any doc changes needed for <https://microsoft.github.io/autogen/>. See <https://github.com/microsoft/autogen/blob/main/CONTRIBUTING.md> to build and test documentation locally. - [ ] I've added tests (if relevant) corresponding to the changes introduced in this PR. - [ ] I've made sure all auto checks have passed. * [dotnet] Add mixin for easier state save/load apis (microsoft#5438) Co-authored-by: Ryan Sweet <[email protected]> * Replace the undefined tools variable with tool_schema parameter in ToolUseAgent class (microsoft#5684) Replace the undefined `tools` variable with `tool_schema` parameter <!-- Thank you for your contribution! Please review https://microsoft.github.io/autogen/docs/Contribute before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? This change keeps the documentation up to date : https://microsoft.github.io/autogen/stable//user-guide/core-user-guide/components/tools.html <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes microsoft#1234" --> ## Checks - [ ] I've included any doc changes needed for <https://microsoft.github.io/autogen/>. See <https://github.com/microsoft/autogen/blob/main/CONTRIBUTING.md> to build and test documentation locally. - [x] I've added tests (if relevant) corresponding to the changes introduced in this PR. - [ ] I've made sure all auto checks have passed. * Improve readme inconsistency (microsoft#5691) ### Before <img width="823" alt="image" src="https://github.com/user-attachments/assets/d5ba1671-9433-4fa4-9884-c0de6fafb82e" /> ### After <img width="803" alt="image" src="https://github.com/user-attachments/assets/07fdd32a-d2ad-450d-8b7f-b21f10f14c85" /> * pack agenthost as tool (microsoft#5647) <!-- Thank you for your contribution! Please review https://microsoft.github.io/autogen/docs/Contribute before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? convenience - allows to just run "agenthost" ``` dotnet pack --no-build --configuration Release --output './output/release' -bl\n dotnet tool install --add-source ./output/release Microsoft.AutoGen.AgentHost agenthost ``` <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes microsoft#1234" --> closes microsoft#5646 ## Checks - [ ] I've included any doc changes needed for <https://microsoft.github.io/autogen/>. See <https://github.com/microsoft/autogen/blob/main/CONTRIBUTING.md> to build and test documentation locally. - [ ] I've added tests (if relevant) corresponding to the changes introduced in this PR. - [ ] I've made sure all auto checks have passed. * update versions to 0.4.8 (microsoft#5689) * Update issue templates (microsoft#5686) * doc & sample: Update documentation for human-in-the-loop and UserProxyAgent; Add UserProxyAgent to ChainLit sample; (microsoft#5656) Resolves microsoft#5610 And address various questions regarding to how to use user proxy agent and human-in-the-loop. * doc: Update SelectorGroupChat doc on how to use O3-mini model. (microsoft#5657) Resolves microsoft#5408 Co-authored-by: Jack Gerrits <[email protected]> * Add metadata field to basemessage (microsoft#5372) Add metadata field to BaseMessage. Why? - additional metadata field can track 1) timestamp if needed, 2) flags about the message. For instance, a use case is a metadata field {"internal":"yes"} that would hide messages from being displayed in an application or studio. As long as an extra field is added to basemessage that is not consumed by existing agents, I am happy. Notes: - We can also only add it to BaseChatMessage, that would be fine - I don't care what the extra field is called as long as there is an extra field somewhere - I don't have preference for the type, a str could work, but a dict would be more useful. --------- Co-authored-by: Eric Zhu <[email protected]> * Change base image to one with arm64 support (microsoft#5681) --------- Co-authored-by: Eric Zhu <[email protected]> Co-authored-by: Ryan Sweet <[email protected]> Co-authored-by: Jack Gerrits <[email protected]> Co-authored-by: Shubham Shukla <[email protected]> Co-authored-by: gagb <[email protected]> Co-authored-by: Hussein Mozannar <[email protected]>
Add metadata field to BaseMessage.
Why?
As long as an extra field is added to basemessage that is not consumed by existing agents, I am happy.
Notes: