From 5669e926291759d174399b927b9b1de746172e72 Mon Sep 17 00:00:00 2001 From: "W. Michael Petullo" Date: Tue, 21 Jan 2025 12:01:34 -0600 Subject: [PATCH] Fix build with Go 1.24 Go 1.24 provides stricter checking that forbids passing a variable as a format string to Printf-like functions with no other arguments. Remove instances of this. See also: https://tip.golang.org/doc/go1.24#vet Signed-off-by: W. Michael Petullo --- azuredevops/models_test.go | 6 +++--- azuredevops/v6/models_test.go | 6 +++--- azuredevops/v7/models_test.go | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/azuredevops/models_test.go b/azuredevops/models_test.go index a82af51f..0d4fa82a 100644 --- a/azuredevops/models_test.go +++ b/azuredevops/models_test.go @@ -27,7 +27,7 @@ func TestModels_Unmarshal_Time(t *testing.T) { parsedTime, err := time.Parse(time.RFC3339Nano, "2019-09-01T00:07:26Z") if err != nil { - t.Errorf(err.Error()) + t.Error(err.Error()) } if testModel.Time2.Time != parsedTime { t.Errorf("Expected time: %v Actual time: %v", parsedTime, testModel.Time2.Time) @@ -46,13 +46,13 @@ func TestModels_Marshal_Unmarshal_Time(t *testing.T) { testModel1.Time1.Time = time.Now() b, err := json.Marshal(testModel1) if err != nil { - t.Errorf(err.Error()) + t.Error(err.Error()) } testModel2 := TestModel{} err = json.Unmarshal(b, &testModel2) if err != nil { - t.Errorf(err.Error()) + t.Error(err.Error()) } if testModel1.Time1 != testModel1.Time1 { diff --git a/azuredevops/v6/models_test.go b/azuredevops/v6/models_test.go index a82af51f..0d4fa82a 100644 --- a/azuredevops/v6/models_test.go +++ b/azuredevops/v6/models_test.go @@ -27,7 +27,7 @@ func TestModels_Unmarshal_Time(t *testing.T) { parsedTime, err := time.Parse(time.RFC3339Nano, "2019-09-01T00:07:26Z") if err != nil { - t.Errorf(err.Error()) + t.Error(err.Error()) } if testModel.Time2.Time != parsedTime { t.Errorf("Expected time: %v Actual time: %v", parsedTime, testModel.Time2.Time) @@ -46,13 +46,13 @@ func TestModels_Marshal_Unmarshal_Time(t *testing.T) { testModel1.Time1.Time = time.Now() b, err := json.Marshal(testModel1) if err != nil { - t.Errorf(err.Error()) + t.Error(err.Error()) } testModel2 := TestModel{} err = json.Unmarshal(b, &testModel2) if err != nil { - t.Errorf(err.Error()) + t.Error(err.Error()) } if testModel1.Time1 != testModel1.Time1 { diff --git a/azuredevops/v7/models_test.go b/azuredevops/v7/models_test.go index a82af51f..0d4fa82a 100644 --- a/azuredevops/v7/models_test.go +++ b/azuredevops/v7/models_test.go @@ -27,7 +27,7 @@ func TestModels_Unmarshal_Time(t *testing.T) { parsedTime, err := time.Parse(time.RFC3339Nano, "2019-09-01T00:07:26Z") if err != nil { - t.Errorf(err.Error()) + t.Error(err.Error()) } if testModel.Time2.Time != parsedTime { t.Errorf("Expected time: %v Actual time: %v", parsedTime, testModel.Time2.Time) @@ -46,13 +46,13 @@ func TestModels_Marshal_Unmarshal_Time(t *testing.T) { testModel1.Time1.Time = time.Now() b, err := json.Marshal(testModel1) if err != nil { - t.Errorf(err.Error()) + t.Error(err.Error()) } testModel2 := TestModel{} err = json.Unmarshal(b, &testModel2) if err != nil { - t.Errorf(err.Error()) + t.Error(err.Error()) } if testModel1.Time1 != testModel1.Time1 {