Skip to content

Commit bac622b

Browse files
authored
Allow null value for Configuration parameter (#4856)
1 parent 702a41f commit bac622b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Diff for: libraries/botbuilder-core/etc/botbuilder-core.api.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ export interface CoreAppCredentials {
394394
}
395395

396396
// @public
397-
export function createBotFrameworkAuthenticationFromConfiguration(configuration: Configuration, credentialsFactory?: ServiceClientCredentialsFactory, authConfiguration?: AuthenticationConfiguration, botFrameworkClientFetch?: (input: RequestInfo, init?: RequestInit) => Promise<Response>, connectorClientOptions?: ConnectorClientOptions): BotFrameworkAuthentication;
397+
export function createBotFrameworkAuthenticationFromConfiguration(configuration: Configuration | null, credentialsFactory?: ServiceClientCredentialsFactory, authConfiguration?: AuthenticationConfiguration, botFrameworkClientFetch?: (input: RequestInfo, init?: RequestInit) => Promise<Response>, connectorClientOptions?: ConnectorClientOptions): BotFrameworkAuthentication;
398398

399399
// @public
400400
export function createServiceClientCredentialFactoryFromConfiguration(configuration: Configuration): ConfigurationServiceClientCredentialFactory;

Diff for: libraries/botbuilder-core/src/configurationBotFrameworkAuthentication.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ export class ConfigurationBotFrameworkAuthentication extends BotFrameworkAuthent
272272
* @returns A [ConfigurationBotFrameworkAuthentication](xref:botbuilder-core.ConfigurationBotFrameworkAuthentication) instance.
273273
*/
274274
export function createBotFrameworkAuthenticationFromConfiguration(
275-
configuration: Configuration,
275+
configuration: Configuration | null,
276276
credentialsFactory?: ServiceClientCredentialsFactory,
277277
authConfiguration?: AuthenticationConfiguration,
278278
botFrameworkClientFetch?: (input: RequestInfo, init?: RequestInit) => Promise<Response>,

0 commit comments

Comments
 (0)