Clarify and Improve the version format script so that it doesn't need to manually be updated every year. Also fixed version.txt not requiring a magic 999 value. (#1237)

Co-authored-by: Tom Tan <[email protected]>

Author: mkoscumb

Solutions/version.txt

@@ -1 +1 @@
-3.8.999.1
+3.year.day.1

tools/version.js

@@ -18,6 +18,11 @@ function dayNumber() {
   return dayOfYear;
 }
 
+function yearNumber() {
+   var thisYear = new Date().getFullYear();
+   return (thisYear - 2016);
+}
+
 var fso = WScript.CreateObject("Scripting.Filesystemobject");
 
 function readAll(filename) {
@@ -27,6 +32,12 @@ function readAll(filename) {
   return result;
 }
 
+function updateYearAndDay(versionString){
+  var updatedVersion = versionString.replace("year", yearNumber());
+  updatedVersion = updatedVersion.replace("day", dayNumber() );
+  return updatedVersion;
+}
+
 function generateVersionHpp() {
 
   var palTxt = "WIN32";
@@ -35,8 +46,7 @@ function generateVersionHpp() {
   var ver1      = readAll("..\\Solutions\\version.txt");
   // Remove end-of-line
   ver1 = ver1.replace("\n", "");
-  // Replace 999 by today's dayNumber for nightly builds
-  ver1 = ver1.replace("999", dayNumber() );
+  ver1 = updateYearAndDay(ver1);
   // console.log("version.txt => " + ver1 + "\n");
   var ver2 = ver1.split(".").join(",");
   var arr  = ver1.split(".");
@@ -68,8 +78,9 @@ function generateVersionHpp() {
 }
 
 function generateVersionTxt() {
-  // Read base version and replace '999' with nightly build number
-  var version = readAll("..\\Solutions\\version.txt").replace("999", dayNumber());
+  var version = readAll("..\\Solutions\\version.txt")
+
+  version = updateYearAndDay(version);
 
   // Create 'out' folder if it doesn't already exist. Otherwise, OpenTextFile below will fail
   if (!fso.FolderExists("..\\Solutions\\out")) {