Prevent -Wcast-function-type-mismatch diagnostics from clang (#1301)

ZacharyHenkel · web-flow · commit 324eb395f34e · 2024-09-12T11:52:00.000-07:00
Merge now because the iOS build issue is unrelated.
diff --git a/lib/include/public/mat.h b/lib/include/public/mat.h
@@ -370,7 +370,8 @@ extern "C" {
     {
 #ifdef _WIN32
         /* This code accepts a handle of a library loaded in customer's code */
-        evt_app_call_t impl = (evt_app_call_t)GetProcAddress((HMODULE)handle, "evt_api_call_default");
+        /* The intermediate (void*) cast prevents incompatible function type cast diagnostics */
+        evt_app_call_t impl = (evt_app_call_t)(void*)GetProcAddress((HMODULE)handle, "evt_api_call_default");
         if (impl != NULL)
         {
             evt_api_call = impl;

Original file line number	Diff line number	Diff line change
`@@ -370,7 +370,8 @@ extern "C" {`
`370`	`370`	`{`
`371`	`371`	`#ifdef _WIN32`
`372`	`372`	`/* This code accepts a handle of a library loaded in customer's code */`
`373`		`- evt_app_call_t impl = (evt_app_call_t)GetProcAddress((HMODULE)handle, "evt_api_call_default");`
	`373`	`+ /* The intermediate (void) cast prevents incompatible function type cast diagnostics /`
	`374`	`+ evt_app_call_t impl = (evt_app_call_t)(void*)GetProcAddress((HMODULE)handle, "evt_api_call_default");`
`374`	`375`	`if (impl != NULL)`
`375`	`376`	`{`
`376`	`377`	`evt_api_call = impl;`