Update a couple member methods which don't access class instance member variables to be static. (#1234)

Co-authored-by: Tom Tan <[email protected]>

Author: mkoscumb

lib/offline/LogSessionDataProvider.hpp

@@ -55,8 +55,8 @@ namespace MAT_NS_BEGIN
         std::string const m_cacheFilePath;
         SessionStorageType m_storageType;
         std::unique_ptr<LogSessionData> m_logSessionData;
-        uint64_t convertStrToLong(const std::string&);
-        void writeFileContents(const std::string&, uint64_t, const std::string&);
+        static uint64_t convertStrToLong(const std::string&);
+        static void writeFileContents(const std::string&, uint64_t, const std::string&);
         void remove_eol(std::string& );
     };
 }

tests/unittests/OfflineStorageTests_SQLite.cpp

@@ -31,7 +31,7 @@ class OfflineStorage_SQLiteNoAutoCommit : public OfflineStorage_SQLite
     }
 
     // Returns the number of active SQLiteDBs
-    int GetDbInstanceCount() {
+    static int GetDbInstanceCount() {
       std::lock_guard<std::mutex> lock(m_initAndShutdownLock);
       return m_instanceCount;
     }
@@ -92,7 +92,7 @@ struct OfflineStorageTests_SQLite : public Test
         }
     }
 
-    bool fileExists(std::string const& filename)
+    static bool fileExists(std::string const& filename)
     {
         return std::ifstream(filename).good();
     }