Skip to content

Commit b382909

Browse files
author
Sid Dahiya
committed
Add more tests
1 parent 999c7cb commit b382909

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

tests/unittests/DefaultDataViewerTests.cpp

+10-8
Original file line numberDiff line numberDiff line change
@@ -148,19 +148,21 @@ TEST(DefaultDataViewerTests, GetEndpoint_CorrectEndpointReturned)
148148
}
149149

150150
//TODO Uncomment this test when the submodule has been updated.
151-
TEST(DefaultDataViewerTests, EnableRemoteViewer_InvalidEndpoint_ThrowsInvalidArgument)
151+
TEST(DefaultDataViewerTests, IsValidRemoteEndpoint_InvalidEndpoint_ReturnsFalse)
152152
{
153153
auto mockHttpClient = std::make_shared<MockHttpClient>();
154154
MockDefaultDataViewer viewer(mockHttpClient, "Test");
155-
ASSERT_FALSE(viewer.EnableRemoteViewer(""));
156-
ASSERT_FALSE(viewer.EnableRemoteViewer(" "));
157-
ASSERT_FALSE(viewer.EnableRemoteViewer("TestEndpoint"));
158-
ASSERT_FALSE(viewer.EnableRemoteViewer("https://10.0.0.1"));
159-
ASSERT_FALSE(viewer.EnableRemoteViewer("HTTps://10.0.0.1"));
160-
ASSERT_FALSE(viewer.EnableRemoteViewer("http://14.0.0.1"));
155+
ASSERT_FALSE(viewer.IsValidRemoteEndpoint(""));
156+
ASSERT_FALSE(viewer.IsValidRemoteEndpoint(""));
157+
ASSERT_FALSE(viewer.IsValidRemoteEndpoint(" "));
158+
ASSERT_FALSE(viewer.IsValidRemoteEndpoint("TestEndpoint"));
159+
ASSERT_FALSE(viewer.IsValidRemoteEndpoint("https://10.0.0.1"));
160+
ASSERT_FALSE(viewer.IsValidRemoteEndpoint("HTTps://10.0.0.1"));
161+
ASSERT_FALSE(viewer.IsValidRemoteEndpoint("http://14.0.0.1"));
162+
ASSERT_FALSE(viewer.IsValidRemoteEndpoint("http://192.168.999.999"));
161163
}
162164

163-
TEST(DefaultDataViewerTests, EnableRemoteViewer_InvalidEndpoint_TransmissionNotEnabled)
165+
TEST(DefaultDataViewerTests, EnableRemoteViewer_NonRespondingEndpoint_TransmissionNotEnabled)
164166
{
165167
auto mockHttpClient = std::make_shared<MockHttpClient>();
166168
mockHttpClient->funcSendRequestAsync = [](MAT::IHttpRequest*, MAT::IHttpResponseCallback* callback)

0 commit comments

Comments
 (0)