Skip to content

Commit 036e4f8

Browse files
authored
implement -s, -w, -W (#147)
1 parent 553f5a1 commit 036e4f8

File tree

4 files changed

+41
-9
lines changed

4 files changed

+41
-9
lines changed

cmd/sqlcmd/main.go

+22-6
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ type SQLCmdArguments struct {
5555
Headers int `short:"h" help:"Specifies the number of rows to print between the column headings. Use -h-1 to specify that headers not be printed."`
5656
UnicodeOutputFile bool `short:"u" help:"Specifies that all output files are encoded with little-endian Unicode"`
5757
Version bool `help:"Show the sqlcmd version information"`
58+
ColumnSeparator string `short:"s" help:"Specifies the column separator character. Sets the SQLCMDCOLSEP variable."`
59+
ScreenWidth *int `short:"w" help:"Specifies the screen width for output. Sets the SQLCMDCOLWIDTH variable."`
60+
TrimSpaces bool `short:"W" help:"Remove trailing spaces from a column."`
5861
// Keep Help at the end of the list
5962
Help bool `short:"?" help:"Show syntax summary."`
6063
}
@@ -68,6 +71,9 @@ func (a *SQLCmdArguments) Validate() error {
6871
if a.Headers < -1 {
6972
return fmt.Errorf(`'-h %d': header value must be either -1 or a value between 1 and 2147483647`, a.Headers)
7073
}
74+
if a.ScreenWidth != nil && (*a.ScreenWidth < 9 || *a.ScreenWidth > 65535) {
75+
return fmt.Errorf(`'-w %d': value must be greater than 8 and less than 65536.`, *a.ScreenWidth)
76+
}
7177
return nil
7278
}
7379

@@ -155,11 +161,21 @@ func setVars(vars *sqlcmd.Variables, args *SQLCmdArguments) {
155161
}
156162
return ""
157163
},
158-
sqlcmd.SQLCMDUSER: func(a *SQLCmdArguments) string { return a.UserName },
159-
sqlcmd.SQLCMDSTATTIMEOUT: func(a *SQLCmdArguments) string { return "" },
160-
sqlcmd.SQLCMDHEADERS: func(a *SQLCmdArguments) string { return fmt.Sprint(a.Headers) },
161-
sqlcmd.SQLCMDCOLSEP: func(a *SQLCmdArguments) string { return "" },
162-
sqlcmd.SQLCMDCOLWIDTH: func(a *SQLCmdArguments) string { return "" },
164+
sqlcmd.SQLCMDUSER: func(a *SQLCmdArguments) string { return a.UserName },
165+
sqlcmd.SQLCMDSTATTIMEOUT: func(a *SQLCmdArguments) string { return "" },
166+
sqlcmd.SQLCMDHEADERS: func(a *SQLCmdArguments) string { return fmt.Sprint(a.Headers) },
167+
sqlcmd.SQLCMDCOLSEP: func(a *SQLCmdArguments) string {
168+
if a.ColumnSeparator != "" {
169+
return string(a.ColumnSeparator[0])
170+
}
171+
return ""
172+
},
173+
sqlcmd.SQLCMDCOLWIDTH: func(a *SQLCmdArguments) string {
174+
if a.ScreenWidth != nil {
175+
return fmt.Sprint(*a.ScreenWidth)
176+
}
177+
return ""
178+
},
163179
sqlcmd.SQLCMDMAXVARTYPEWIDTH: func(a *SQLCmdArguments) string { return "" },
164180
sqlcmd.SQLCMDMAXFIXEDTYPEWIDTH: func(a *SQLCmdArguments) string { return "" },
165181
sqlcmd.SQLCMDFORMAT: func(a *SQLCmdArguments) string { return a.Format },
@@ -246,7 +262,7 @@ func run(vars *sqlcmd.Variables, args *SQLCmdArguments) (int, error) {
246262
}
247263

248264
s.Connect = &connectConfig
249-
s.Format = sqlcmd.NewSQLCmdDefaultFormatter(false)
265+
s.Format = sqlcmd.NewSQLCmdDefaultFormatter(args.TrimSpaces)
250266
if args.OutputFile != "" {
251267
err = s.RunCommand(s.Cmd["OUT"], []string{args.OutputFile})
252268
if err != nil {

cmd/sqlcmd/main_test.go

+4
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,9 @@ func TestValidCommandLineToArgsConversion(t *testing.T) {
8888
{[]string{"--version"}, func(args SQLCmdArguments) bool {
8989
return args.Version
9090
}},
91+
{[]string{"-s", "|", "-w", "10", "-W"}, func(args SQLCmdArguments) bool {
92+
return args.TrimSpaces && args.ColumnSeparator == "|" && *args.ScreenWidth == 10
93+
}},
9194
}
9295

9396
for _, test := range commands {
@@ -117,6 +120,7 @@ func TestInvalidCommandLine(t *testing.T) {
117120
{[]string{"-F", "what"}, "--format must be one of \"horiz\",\"horizontal\",\"vert\",\"vertical\" but got \"what\""},
118121
{[]string{"-r", "5"}, `--errors-to-stderr must be one of "-1","0","1" but got '\x05'`},
119122
{[]string{"-h-4"}, "test: '-h -4': header value must be either -1 or a value between 1 and 2147483647"},
123+
{[]string{"-w", "6"}, "test: '-w 6': value must be greater than 8 and less than 65536."},
120124
}
121125

122126
for _, test := range commands {

go.mod

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ module github.com/microsoft/go-sqlcmd
33
go 1.18
44

55
require (
6-
github.com/alecthomas/kong v0.5.1-0.20220516223738-0aaa4c11997b
6+
github.com/alecthomas/kong v0.6.2-0.20220922001058-c62bf25854a0
77
github.com/golang-sql/sqlexp v0.1.0
88
github.com/google/uuid v1.3.0
99
github.com/microsoft/go-mssqldb v0.17.0
1010
github.com/peterh/liner v1.2.2
11-
github.com/stretchr/testify v1.7.1
11+
github.com/stretchr/testify v1.8.0
1212
golang.org/x/text v0.3.7
1313
)
1414

@@ -27,5 +27,5 @@ require (
2727
golang.org/x/crypto v0.0.0-20220511200225-c6db032c6c88 // indirect
2828
golang.org/x/net v0.0.0-20220425223048-2871e0cb64e4 // indirect
2929
golang.org/x/sys v0.0.0-20220224120231-95c6836cb0e7 // indirect
30-
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b // indirect
30+
gopkg.in/yaml.v3 v3.0.1 // indirect
3131
)

go.sum

+12
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,13 @@ github.com/AzureAD/microsoft-authentication-library-for-go v0.4.0 h1:WVsrXCnHlDD
88
github.com/AzureAD/microsoft-authentication-library-for-go v0.4.0/go.mod h1:Vt9sXTKwMyGcOxSmLDMnGPgqsUg7m8pe215qMLrDXw4=
99
github.com/alecthomas/kong v0.5.1-0.20220516223738-0aaa4c11997b h1:QF7Hdi3ReQRAST66vU7bqkHODmcVJIUZyTGo9gLHluk=
1010
github.com/alecthomas/kong v0.5.1-0.20220516223738-0aaa4c11997b/go.mod h1:GaAkr/DV/nSKftP7snQLewFh9pZqrm+OEn3HqkvWU7c=
11+
github.com/alecthomas/kong v0.6.1 h1:1kNhcFepkR+HmasQpbiKDLylIL8yh5B5y1zPp5bJimA=
12+
github.com/alecthomas/kong v0.6.1/go.mod h1:JfHWDzLmbh/puW6I3V7uWenoh56YNVONW+w8eKeUr9I=
13+
github.com/alecthomas/kong v0.6.2-0.20220922001058-c62bf25854a0 h1:HQ3WlFsqBcr4qsiHtfA7UdFSrChglOcQa8q/tbXJFBI=
14+
github.com/alecthomas/kong v0.6.2-0.20220922001058-c62bf25854a0/go.mod h1:n1iCIO2xS46oE8ZfYCNDqdR0b0wZNrXAIAqro/2132U=
1115
github.com/alecthomas/repr v0.0.0-20210801044451-80ca428c5142 h1:8Uy0oSf5co/NZXje7U1z8Mpep++QJOldL2hs/sBQf48=
1216
github.com/alecthomas/repr v0.0.0-20210801044451-80ca428c5142/go.mod h1:2kn6fqh/zIyPLmm3ugklbEi5hg5wS435eygvNfaDQL8=
17+
github.com/alecthomas/repr v0.1.0 h1:ENn2e1+J3k09gyj2shc0dHr/yjaWSHRlrJ4DPMevDqE=
1318
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
1419
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
1520
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
@@ -44,9 +49,14 @@ github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8/go.mod h1:HKlIX3XHQyzL
4449
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
4550
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
4651
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
52+
github.com/stretchr/objx v0.4.0/go.mod h1:YvHI0jy2hoMjB+UWwv71VJQ9isScKT/TqJzVSSt89Yw=
4753
github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
4854
github.com/stretchr/testify v1.7.1 h1:5TQK59W5E3v0r2duFAb7P95B6hEeOyEnHRa8MjYSMTY=
4955
github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
56+
github.com/stretchr/testify v1.7.2 h1:4jaiDzPyXQvSd7D0EjG45355tLlV3VOECpq10pLC+8s=
57+
github.com/stretchr/testify v1.7.2/go.mod h1:R6va5+xMeoiuVRoj+gSkQ7d3FALtqAAGI1FQKckRals=
58+
github.com/stretchr/testify v1.8.0 h1:pSgiaMZlXftHpm5L7V1+rVB+AZJydKsMxsQBIJw4PKk=
59+
github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU=
5060
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
5161
golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
5262
golang.org/x/crypto v0.0.0-20220511200225-c6db032c6c88 h1:Tgea0cVUD0ivh5ADBX4WwuI12DUd2to3nCYe2eayMIw=
@@ -85,3 +95,5 @@ gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
8595
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
8696
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b h1:h8qDotaEPuJATrMmW04NCwg7v22aHH28wwpauUhK9Oo=
8797
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
98+
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
99+
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

0 commit comments

Comments
 (0)