Fix code style warnings and code clean up (#517)

Author: dluc

applications/evaluation/Evaluators/AnswerCorrectness/StatementEvaluation.cs

@@ -1,5 +1,7 @@
 // Copyright (c) Microsoft. All rights reserved.
 
+// ReSharper disable CheckNamespace
+
 namespace Microsoft.KernelMemory.Evaluators.AnswerCorrectness;
 
 #pragma warning disable CA1812 // 'StatementEvaluation' is an internal class that is apparently never instantiated. If so, remove the code from the assembly. If this class is intended to contain only static members, make it 'static' (Module in Visual Basic). (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1812)

applications/evaluation/Evaluators/ContextRecall/GroundTruthClassification.cs

@@ -1,5 +1,7 @@
 // Copyright (c) Microsoft. All rights reserved.
 
+// ReSharper disable CheckNamespace
+
 namespace Microsoft.KernelMemory.Evaluators.ContextRecall;
 
 #pragma warning disable CA1812 // 'GroundTruthClassification' is an internal class that is apparently never instantiated. If so, remove the code from the assembly. If this class is intended to contain only static members, make it 'static' (Module in Visual Basic). (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1812)

applications/evaluation/Evaluators/ContextRelevancy/ContextRelevancy.cs

@@ -1,5 +1,7 @@
 // Copyright (c) Microsoft. All rights reserved.
 
+// ReSharper disable CheckNamespace
+
 namespace Microsoft.KernelMemory.Evaluators.ContextRelevancy;
 
 #pragma warning disable CA1812 // 'ContextRelevancy' is an internal class that is apparently never instantiated. If so, remove the code from the assembly. If this class is intended to contain only static members, make it 'static' (Module in Visual Basic). (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1812)

applications/evaluation/Evaluators/Faithfulness/StatementEvaluation.cs

@@ -1,5 +1,7 @@
 // Copyright (c) Microsoft. All rights reserved.
 
+// ReSharper disable CheckNamespace
+
 namespace Microsoft.KernelMemory.Evaluators.Faithfulness;
 
 #pragma warning disable CA1812 // 'StatementEvaluation' is an internal class that is apparently never instantiated. If so, remove the code from the assembly. If this class is intended to contain only static members, make it 'static' (Module in Visual Basic). (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1812)

applications/evaluation/Evaluators/Relevance/RelevanceEvaluation.cs

@@ -1,5 +1,7 @@
 // Copyright (c) Microsoft. All rights reserved.
 
+// ReSharper disable CheckNamespace
+
 namespace Microsoft.KernelMemory.Evaluators.Relevance;
 
 #pragma warning disable CA1812 // 'RelevanceEvaluation' is an internal class that is apparently never instantiated. If so, remove the code from the assembly. If this class is intended to contain only static members, make it 'static' (Module in Visual Basic). (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1812)

clients/dotnet/SemanticKernelPlugin/Internals/TypeConverter.cs

@@ -9,14 +9,10 @@
 namespace Microsoft.KernelMemory.SemanticKernelPlugin.Internals;
 
 [TypeConverter(typeof(TypeConverter))]
-public class TagCollectionWrapper : TagCollection
-{
-}
+public class TagCollectionWrapper : TagCollection;
 
 [TypeConverter(typeof(TypeConverter))]
-public class ListOfStringsWrapper : List<string>
-{
-}
+public class ListOfStringsWrapper : List<string>;
 
 #pragma warning disable CA1812 // required by SK
 internal sealed class TypeConverter : System.ComponentModel.TypeConverter

examples/001-dotnet-WebClient/Program.cs

@@ -1,8 +1,5 @@
 // Copyright (c) Microsoft. All rights reserved.
 
-// ReSharper disable InconsistentNaming
-// ReSharper disable CommentTypo
-
 #pragma warning disable CS8602 // memory is initialized before usage
 #pragma warning disable CS0162 // unreachable code is managed via boolean settings
 
@@ -504,18 +501,18 @@ Azure Active Directory (AAD) authentication mechanism. To test this locally, you
     // Download file and print details
     private static async Task DownloadFile()
     {
-        const string filename = "file1-Wikipedia-Carbon.txt";
+        const string Filename = "file1-Wikipedia-Carbon.txt";
 
         Console.WriteLine("Downloading file");
-        StreamableFileContent result = await s_memory.ExportFileAsync(documentId: "doc001", fileName: filename);
+        StreamableFileContent result = await s_memory.ExportFileAsync(documentId: "doc001", fileName: Filename);
         var stream = new MemoryStream();
         await (await result.GetStreamAsync()).CopyToAsync(stream);
         var bytes = stream.ToArray();
 
         Console.WriteLine();
-        Console.WriteLine("Original File name : " + filename);
-        Console.WriteLine("Original File size : " + new FileInfo(filename).Length);
-        Console.WriteLine("Original Bytes count: " + (await File.ReadAllBytesAsync(filename)).Length);
+        Console.WriteLine("Original File name : " + Filename);
+        Console.WriteLine("Original File size : " + new FileInfo(Filename).Length);
+        Console.WriteLine("Original Bytes count: " + (await File.ReadAllBytesAsync(Filename)).Length);
         Console.WriteLine();
         Console.WriteLine("Downloaded File name : " + result.FileName);
         Console.WriteLine("Downloaded File type : " + result.FileType);

examples/003-dotnet-SemanticKernel-plugin/Program.cs

@@ -6,7 +6,6 @@
 
 public static class Program
 {
-    // ReSharper disable InconsistentNaming
     public static async Task Main()
     {
         const string DocFilename = "mydocs-NASA-news.pdf";

examples/101-dotnet-custom-Prompts/Program.cs

@@ -5,7 +5,6 @@
 
 public static class Program
 {
-    // ReSharper disable InconsistentNaming
     public static async Task Main()
     {
         var azureOpenAITextConfig = new AzureOpenAIConfig();

examples/106-dotnet-retrieve-synthetics/Program.cs

@@ -45,7 +45,6 @@ await memory.ImportDocumentAsync(new Document("doc1")
     Console.WriteLine($"== {result.SourceName} summary ==\n{result.Partitions.First().Text}\n");
 }
 
-// ReSharper disable CommentTypo
 /*
 
 OUTPUT: