Fix retry logic in UFS device detection APIs #1577
Open
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NishanthSanjeevi
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202502 #1577 +/- ##
=================================================
Coverage ? 1.55%
=================================================
Files ? 636
Lines ? 233989
Branches ? 370
=================================================
Hits ? 3649
Misses ? 230327
Partials ? 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
makubacki
approved these changes
Nov 19, 2025
Member
makubacki
left a comment
makubacki
left a comment
There was a problem hiding this comment.
It would be preferable to have more granular error codes, but looking through the UFS code, they're all mixed up, so this seems reasonable.
makubacki
reviewed
Nov 19, 2025
Member
|
Also, please create a PR in edk2 (without the MU_CHANGE tags). We don't need to wait on it to merge this. |
os-d
approved these changes
Nov 19, 2025
Member
|
@NishanthSanjeevi, please push the uncrustify update when you get a chance. I've set automerge so it will merge when that's done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the retry logic in the UFS device detection APIs
How This Was Tested
Tested on physical Hardware
Integration Instructions
N/A