Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: AddOn VGA display is not working due to GOP from the addon VGA is loaded after console out connection #636

Open
1 task done
MarcChen46 opened this issue Feb 19, 2025 · 4 comments
Open
1 task done

[Bug]: AddOn VGA display is not working due to GOP from the addon VGA is loaded after console out connection #636

MarcChen46 opened this issue Feb 19, 2025 · 4 comments
Labels
state:needs-maintainer-feedback Needs more information from a maintainer to determine next steps state:needs-owner Needs an issue owner to be assigned state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:medium Important with a moderate impact

Comments

@MarcChen46
Copy link
Contributor

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

in current implementation of PlatformBootManagerLib, the GOP option ROM from addon VGA card is loaded after console out connection, and the addon VGA display is not working due to it, if we adjust the EfiBootManagerDispatchDeferredImages prior to DeviceBootManagerBeforeConsole, then the issue can be resolved.

In edk2 and edk2-platform repos, there are also some examples of doing console connection after option ROM as below.

OvmfPkg
UefiPayloadPkg
AMD ChachaniBoardPkg

Expected Behavior

The console out connection should also be performed after GOP option ROM get loaded to make the display from addon VGA work

Steps To Reproduce

  1. System that only has addon VGA card and plug monitor with the addon VGA card.
  2. Power on the system
  3. Boot to EFI Shell
  4. No display from addon VGA

Build Environment

- OS(s): Windows11
- Tool Chain(s): VS2022
- Targets Impacted: all systems that use addon VGA card as primary video controller.

Version Information

v2024050001.0.4

Urgency

Medium

Are you going to fix this?

Someone else needs to fix it

Do you need maintainer feedback?

Maintainer feedback requested

Anything else?

No response
@MarcChen46 MarcChen46 added state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working labels Feb 19, 2025
@github-actions github-actions bot added state:needs-maintainer-feedback Needs more information from a maintainer to determine next steps urgency:medium Important with a moderate impact state:needs-owner Needs an issue owner to be assigned labels Feb 19, 2025
@MarcChen46
Copy link
Contributor Author

@apop5 @kuqin12 @makuback, please take a look and provide your comment, thanks.

@makubacki
Copy link
Member

@MarcChen46, as mentioned in another thread, a key requirement is that ExitPmAuth (EndOfDxe & SmmReadyToLock) occurs prior to dispatching deferred images. Are there other changes needed in this library instance for your platform or is this the only issue?

@MarcChen46
Copy link
Contributor Author

@makubacki, thanks for reply, move both ExitPmAuth and EfiBootManagerDispatchDeferredImages prior to console out connection is the only required change for resolve the addon VGA display issue.

@makubacki
Copy link
Member

Thanks @MarcChen46, @apop5 should follow up with you soon after an offline discussion within our team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state:needs-maintainer-feedback Needs more information from a maintainer to determine next steps state:needs-owner Needs an issue owner to be assigned state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:medium Important with a moderate impact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@makubacki @MarcChen46