xtask: Copyright and license lints for more file types #769
+77
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Likely more fixes might be needed. Not familiar with the code, going to learn empirically, through CI errors. |
|
Thanks for sending out a follow-up! See my comments on the issue for some potential pitfalls you might run into here :) |
Unless anything requires the #! in the .py file, I think we can just remove it... |
smalis-msft
previously approved these changes
Feb 6, 2025
daprilik
requested changes
Feb 6, 2025
romank-msft
force-pushed
the
larger_house
branch
from
cfd4acf to
0660cca
Compare
Few files turned out to not have the notes, and they were fixed manually. Provide a robust solution by updating house rules in xtask. Additionally this includes an updatex for the automatic fix mode. I made sure that produces desired results and is idempotent Suggested-by: Daniel Prilik <[email protected]> Reported-by: Matt Kurjanowicz <[email protected]> Fixes: microsoft#766
romank-msft
force-pushed
the
larger_house
branch
from
0660cca to
233fe76
Compare
smalis-msft
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few files turned out to not have the notes, and they were fixed
manually.
Provide a robust solution by updating house rules in xtask.
Additionally this includes an updatex for the automatic fix
mode. I made sure that produces desired results and is
idempotent.
Suggested-by: Daniel Prilik [email protected]
Reported-by: Matt Kurjanowicz [email protected]
Fixes: #766