Skip to content

Commit 8264bec

Browse files
authored
fix(ff): stop gap for setInputFiles race (#29696)
1 parent 321e9d7 commit 8264bec

File tree

1 file changed

+7
-9
lines changed
  • packages/playwright-core/src/server/firefox

1 file changed

+7
-9
lines changed

packages/playwright-core/src/server/firefox/ffPage.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -544,15 +544,13 @@ export class FFPage implements PageDelegate {
544544
}
545545

546546
async setInputFilePaths(progress: Progress, handle: dom.ElementHandle<HTMLInputElement>, files: string[]): Promise<void> {
547-
await Promise.all([
548-
this._session.send('Page.setFileInputFiles', {
549-
frameId: handle._context.frame._id,
550-
objectId: handle._objectId,
551-
files
552-
}),
553-
handle.dispatchEvent(progress.metadata, 'input'),
554-
handle.dispatchEvent(progress.metadata, 'change')
555-
]);
547+
await this._session.send('Page.setFileInputFiles', {
548+
frameId: handle._context.frame._id,
549+
objectId: handle._objectId,
550+
files
551+
});
552+
await handle.dispatchEvent(progress.metadata, 'input');
553+
await handle.dispatchEvent(progress.metadata, 'change');
556554
}
557555

558556
async adoptElementHandle<T extends Node>(handle: dom.ElementHandle<T>, to: dom.FrameExecutionContext): Promise<dom.ElementHandle<T>> {

0 commit comments

Comments
 (0)