-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: toHaveScreenshot sometimes not showing actual/diff on error for webkit #34565
Comments
Please provide a complete and minimal repro of this issue. Otherwise we cannot diagnose it. |
@dimkin-eu If there is no actual screenshot, that means screenshot action did timeout without being able to take a single screenshot. If your environment is slow, perhaps increasing a timeout would help. Otherwise, that could be a bug where screenshot just hangs, but we would need a repro to be able to fix it. |
@dgozman env is ok, trace is recording ( and saved ), parallelly tests were running, test before and after is passing for same device. Same happens in 1.50.1 :( |
JFYI added some debug logs
what I can see from the trace - page in the timeline is alive, but in step's snapshot is blanc |
Re: canvas - the recent changes were about canvas in tracing. If you disable tracing, does the problem still persist? If so, perhaps running with |
Yes, turning off trace doesn't fail tests anymore. Previously it was
|
Maybe this could give a hint Not exactly my bug, but some common things - canvas shown in timeline, but not shown in snapshot projects: [
{
name: "iPhone 11",
use: {
...devices["iPhone 11"],
},
}
], import {expect, test} from '@playwright/test'
test.describe("describe", () => {
test("short storybook spec", async ({page}) => {
await page.goto("https://zimjs.com/parallax.html")
await expect(page).toHaveScreenshot(`foobar.png`, {
scale: "css",
caret: "hide",
animations: "allow",
})
})
}) |
Version
1.50.0
Steps to reproduce
I understand this is a very vague description, but I can't find any consistent pattern.
It happens for 1-2 tests out of 2K+, but this fail the whole job :(
The only idea that comes to my mind - the page wasn't stable to assert a screenshot, but animations are disabled by our code - anyway some actual screenshot must be there
Expected behavior
on error 3 images produced
Actual behavior
only expected image in stacktrace/report
Additional context
No response
Environment
The text was updated successfully, but these errors were encountered: