Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] vscode extension feedback #34568

Open
8 of 23 tasks
dgozman opened this issue Jan 31, 2025 · 4 comments
Open
8 of 23 tasks

[internal] vscode extension feedback #34568

dgozman opened this issue Jan 31, 2025 · 4 comments
Assignees
Labels

Comments

@dgozman
Copy link
Contributor

dgozman commented Jan 31, 2025

  • left sidebar
    • need more padding at the right, because scroller on mac?
    • love the title for "Show browser" checkbox, would like similar for all other controls
    • all <select>s have funky background on hover
  • test explorer
    • sort disabled projects by config, then by project index
    • reveal disabled project upon clicking play?
  • bottom drawer:
    • "Locator"/"Aria" text labels do not look aligned
    • locator/aria textboxes lack background to indicate they are editable
    • icon for pick locator disappeared after some time
    • a button to show aria snapshot for the manually entered locator would be nice
    • immediately went to the drawer to engage recording, but it was not there
    • nice indication that aria snapshot is bad, but no such indication for a bad locator
    • aria error is rendered as a single line, probably intended to be multiline
      - foo
      - "a": "
      - b: bar
      
    • bad aria "text value should be a string" error for:
      - document:
        - text:
        - text: "foo bar"
      
  • recorder
    • assert snaphsot button does not work on about:blank
    • assert text/snapshot do not show the locator at all while hovering
    • after picking locator I miss focusing VSCode
    • assert snapshot generated wrong indentation for the last line with a closing quote
  • running tests
    • running in two browsers shows both, the only way to close is "Close all browsers" button
    • whitespace-only snapshot is not considered "missing"
    • love the install browsers prompt!
    • when running a test with <<<<<<< markers, perhaps say that in the error message?
    • no Windows-specific issues found so far, except for "very slow" :)
    • debugging works
@debs-obrien
Copy link
Collaborator

debs-obrien commented Feb 4, 2025

Love the new Playwright section for locator picker but its super hidden because we have lost scroll for the panel so you need to go full screen of the panel to scroll across and see it. i know it opens when you click it but i found it useful to just open it from the panel and then click the locator button from there.

Also previously you could close this panel, test results etc but due to scroll issue you can't get to the X to close it

@debs-obrien
Copy link
Collaborator

love that it shows the projects as disabled and clicking the play button gives a nice message with button to enable. However there is weird behaviour in my opinion when working with multiple configs. If I toggle to config-2 it shows all tests with projects enabled/disabled however when I run a test from config-1 the tests run but the playwright sidebar shows I am on config-2 and that is a bit confusing as i would expect it to switch configs if i run tests from that config rather than show 1 config but run tests from another one

@aaronmeinel
Copy link

Is the extension also supposed to be usable with pytest-playwright?

@mxschmitt
Copy link
Member

Is the extension also supposed to be usable with pytest-playwright?

The extension works only with Node.js and @playwright/test the official Playwright test-runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants