refactor(Pods): Allow specifying target platform (#91)

Author: tido64

example/ios/Podfile.lock

@@ -1,7 +1,7 @@
 PODS:
   - boost-for-react-native (1.63.0)
   - DoubleConversion (1.1.6)
-  - Example-Tests (0.0.13):
+  - Example-Tests (0.0.14):
     - React
   - Folly (2018.10.22.00):
     - boost-for-react-native
@@ -82,7 +82,7 @@ PODS:
     - React-Core (= 0.60.6)
   - React-RCTWebSocket (0.60.6):
     - React-Core (= 0.60.6)
-  - ReactTestApp-DevSupport (0.0.13)
+  - ReactTestApp-DevSupport (0.0.14)
   - ReactTestApp-Resources (1.0.0-dev)
   - SwiftLint (0.39.1)
   - yoga (0.60.6.React)
@@ -174,7 +174,7 @@ EXTERNAL SOURCES:
 SPEC CHECKSUMS:
   boost-for-react-native: 39c7adb57c4e60d6c5479dd8623128eb5b3f0f2c
   DoubleConversion: 5805e889d232975c086db112ece9ed034df7a0b2
-  Example-Tests: abfe5bd8e60d7a710889bb681b9b4cbb6ced86e5
+  Example-Tests: 89126626c7905017d8c49e0817b87623d9b09266
   Folly: 30e7936e1c45c08d884aa59369ed951a8e68cf51
   glog: 1f3da668190260b06b429bb211bfbee5cd790c28
   QRCodeReader.swift: 373a389fe9a22d513c879a32a6f647c58f4ef572
@@ -195,8 +195,8 @@ SPEC CHECKSUMS:
   React-RCTText: d91537e29e38dc69cf09cbca0875cf5dc7402da6
   React-RCTVibration: 7655d72dfb919dd6d8e135ca108a5a2bd9fcd7b4
   React-RCTWebSocket: 7cd2c8d0f8ddd680dc76404defba7ab1f56b83af
-  ReactTestApp-DevSupport: fc28c1c32fce792379542f36b38fc44c335a50da
-  ReactTestApp-Resources: d25032e61dffcd03da09f537f9a7bab33613e2f0
+  ReactTestApp-DevSupport: 7b8bf85ce84176899550a1556b4f9f2fc39f6a9f
+  ReactTestApp-Resources: c070f72dfcb2806d922eec6656259cbf7a4d2bcf
   SwiftLint: 55e96a4a4d537d4a3156859fc1c54bd24851a046
   yoga: 5079887aa3e4c62142d6bcee493022643ee4d730
 

ios/test_app.rb

@@ -0,0 +1,175 @@
+#
+# Copyright (c) Microsoft Corporation. All rights reserved.
+#
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
+#
+
+require('json')
+require('pathname')
+
+def assert(condition, message)
+  raise message unless condition
+end
+
+def autolink_script_path
+  package_path = resolve_module('@react-native-community/cli-platform-ios')
+  File.join(package_path, 'native_modules')
+end
+
+def find_file(file_name, current_dir)
+  return if current_dir.expand_path.to_s == '/'
+
+  path = current_dir + file_name
+  return path if File.exist?(path)
+
+  find_file(file_name, current_dir.parent)
+end
+
+def find_project_root
+  podfile_path = Thread.current.backtrace_locations.find do |location|
+    File.basename(location.absolute_path) == 'Podfile'
+  end
+  assert(!podfile_path.nil?, "Could not find 'Podfile'")
+
+  Pathname.new(File.dirname(podfile_path.absolute_path))
+end
+
+def nearest_node_modules(project_root)
+  path = find_file('node_modules', project_root)
+  assert(!path.nil?, "Could not find 'node_modules'")
+
+  path
+end
+
+def resolve_module(request)
+  script = "console.log(path.dirname(require.resolve('#{request}/package.json')));"
+  Pod::Executable.execute_command('node', ['-e', script], true).strip
+end
+
+def resolve_resources(manifest, target_platform)
+  resources = manifest['resources']
+  return if !resources || resources.empty?
+
+  resources.instance_of?(Array) ? resources : resources[target_platform.to_s]
+end
+
+def resources_pod(project_root, target_platform)
+  app_manifest = find_file('app.json', project_root)
+  return if app_manifest.nil?
+
+  resources = resolve_resources(JSON.parse(File.read(app_manifest)), target_platform)
+  return if !resources.instance_of?(Array) || resources.empty?
+
+  spec = {
+    'name' => 'ReactTestApp-Resources',
+    'version' => '1.0.0-dev',
+    'summary' => 'Resources for ReactTestApp',
+    'homepage' => 'https://github.com/microsoft/react-native-test-app',
+    'license' => 'Unlicense',
+    'authors' => '@microsoft/react-native-test-app',
+    'source' => { 'git' => 'https://github.com/microsoft/react-native-test-app.git' },
+    'platforms' => {
+      'ios' => '12.0',
+      'osx' => '10.14'
+    },
+    'resources' => resources
+  }
+
+  app_dir = File.dirname(app_manifest)
+  podspec_path = File.join(app_dir, 'ReactTestApp-Resources.podspec.json')
+  File.write(podspec_path, spec.to_json)
+  at_exit { File.delete(podspec_path) if File.exist?(podspec_path) }
+  Pathname.new(app_dir).relative_path_from(project_root).to_s
+end
+
+def use_react_native!(project_root, target_platform)
+  react_native = Pathname.new(resolve_module('react-native'))
+
+  package_json = JSON.parse(File.read(File.join(react_native.to_s, 'package.json')))
+  version = package_json['version'].match(/(?<major>\d+)\.(?<minor>\d+)\.(?<patch>\d+)/)
+
+  if version[:major] == '0' && version[:minor] == '60'
+    require_relative('use_react_native-0.60')
+  elsif version[:major] == '0' && version[:minor] == '61'
+    require_relative('use_react_native-0.61')
+  else
+    raise "Unsupported React Native version: #{version[0]}"
+  end
+
+  include_react_native!(react_native.relative_path_from(project_root).to_s, target_platform)
+end
+
+def use_test_app_internal!(target_platform)
+  assert(%i[ios macos].include?(target_platform), "Unsupported platform: #{target_platform}")
+
+  xcodeproj = 'ReactTestApp.xcodeproj'
+  src_xcodeproj = File.join(__dir__, '..', target_platform.to_s, xcodeproj)
+  project_root = find_project_root
+  destination = File.join(nearest_node_modules(project_root), '.generated')
+  dst_xcodeproj = File.join(destination, xcodeproj)
+
+  # Copy/link Xcode project files
+  FileUtils.mkdir_p(dst_xcodeproj)
+  FileUtils.cp(File.join(src_xcodeproj, 'project.pbxproj'), dst_xcodeproj)
+  FileUtils.ln_sf(File.join(src_xcodeproj, 'xcshareddata'), dst_xcodeproj)
+
+  # Link source files
+  %w[ReactTestApp ReactTestAppTests ReactTestAppUITests].each do |file|
+    FileUtils.ln_sf(File.join(__dir__, '..', 'ios', file), destination)
+  end
+
+  require_relative(autolink_script_path)
+
+  platform :ios, '12.0' if target_platform == :ios
+  platform :osx, '10.14' if target_platform == :macos
+
+  project dst_xcodeproj
+
+  target 'ReactTestApp' do
+    pod 'QRCodeReader.swift' if target_platform == :ios
+    pod 'SwiftLint'
+
+    use_react_native!(project_root, target_platform)
+
+    if (resources_pod_path = resources_pod(project_root, target_platform))
+      pod 'ReactTestApp-Resources', :path => resources_pod_path
+    end
+
+    yield ReactTestAppTargets.new(self)
+
+    use_native_modules! '.'
+  end
+
+  post_install do
+    puts ''
+    puts 'NOTE'
+    puts "  `#{xcodeproj}` was sourced from `react-native-test-app`"
+    puts '  All modifications will be overwritten next time you run `pod install`'
+    puts ''
+  end
+end
+
+class ReactTestAppTargets
+  def initialize(podfile)
+    @podfile = podfile
+  end
+
+  def app
+    yield if block_given?
+  end
+
+  def tests
+    @podfile.target 'ReactTestAppTests' do
+      @podfile.inherit! :search_paths
+      yield if block_given?
+    end
+  end
+
+  def ui_tests
+    @podfile.target 'ReactTestAppUITests' do
+      @podfile.inherit! :search_paths
+      yield if block_given?
+    end
+  end
+end

ios/use_react_native-0.60.rb

@@ -6,7 +6,9 @@
 #
 # rubocop:disable Layout/LineLength
 
-def include_react_native!(react_native)
+def include_react_native!(react_native, target_platform)
+  react_native = "#{react_native}-macos" if target_platform == :macos
+
   pod 'React', :path => react_native
   pod 'React-Core', :path => "#{react_native}/React", :inhibit_warnings => true
   pod 'React-DevSupport', :path => "#{react_native}/React"

ios/use_react_native-0.61.rb

@@ -6,7 +6,9 @@
 #
 # rubocop:disable Layout/LineLength
 
-def include_react_native!(react_native)
+def include_react_native!(react_native, target_platform)
+  react_native = "#{react_native}-macos" if target_platform == :macos
+
   pod 'FBLazyVector', :path => "#{react_native}/Libraries/FBLazyVector"
   pod 'FBReactNativeSpec', :path => "#{react_native}/Libraries/FBReactNativeSpec"
   pod 'RCTRequired', :path => "#{react_native}/Libraries/RCTRequired"

macos/test_app.rb

@@ -0,0 +1,14 @@
+#
+# Copyright (c) Microsoft Corporation. All rights reserved.
+#
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
+#
+
+require_relative('../ios/test_app.rb')
+
+def use_test_app!
+  use_test_app_internal!(:macos) do |target|
+    yield target if block_given?
+  end
+end

test/fixtures/with_ios_resources/app.json

@@ -0,0 +1,20 @@
+{
+  "name": "TestFixture",
+  "displayName": "TestFixture",
+  "components": [
+    {
+      "appKey": "TestFixture",
+      "displayName": "Test"
+    }
+  ],
+  "resources": {
+    "ios": [
+      "dist-ios/assets",
+      "dist-ios/main.jsbundle"
+    ],
+    "macos": [
+      "dist-macos/assets",
+      "dist-macos/main.jsbundle"
+    ]
+  }
+}

test/fixtures/with_platform_resources/app.json

@@ -1,11 +1,12 @@
 {
   "name": "TestFixture",
   "displayName": "TestFixture",
-  "components": {
-    "TestFixture": {
+  "components": [
+    {
+      "appKey": "TestFixture",
       "displayName": "Test"
     }
-  },
+  ],
   "resources": [
     "dist/assets",
     "dist/main.jsbundle"

test/fixtures/with_ios_resources/ios/.gitignore renamed to test/fixtures/with_platform_resources/ios/.gitignore

@@ -0,0 +1,2 @@
+*
+!.gitignore

test/fixtures/without_ios_resources/ios/.gitignore renamed to test/fixtures/with_platform_resources/macos/.gitignore

@@ -1,11 +1,12 @@
 {
   "name": "TestFixture",
   "displayName": "TestFixture",
-  "components": {
-    "TestFixture": {
+  "components": [
+    {
+      "appKey": "TestFixture",
       "displayName": "Test"
     }
-  },
+  ],
   "resources": {
   }
 }

test/fixtures/with_resources/app.json

@@ -0,0 +1,2 @@
+*
+!.gitignore

test/fixtures/with_resources/macos/.gitignore

@@ -0,0 +1,2 @@
+*
+!.gitignore

test/fixtures/without_ios_resources/app.json renamed to test/fixtures/without_platform_resources/app.json

@@ -1,9 +1,10 @@
 {
   "name": "TestFixture",
   "displayName": "TestFixture",
-  "components": {
-    "TestFixture": {
+  "components": [
+    {
+      "appKey": "TestFixture",
       "displayName": "Test"
     }
-  }
+  ]
 }

test/fixtures/without_platform_resources/ios/.gitignore

@@ -0,0 +1,2 @@
+*
+!.gitignore