Skip to content

Commit 2b375c7

Browse files
authored
fix: Add platform extension to output bundles (#109)
1 parent 82d811c commit 2b375c7

File tree

3 files changed

+17
-13
lines changed

3 files changed

+17
-13
lines changed

example/app.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,17 @@
88
}
99
],
1010
"resources": {
11+
"android": [
12+
"dist/res",
13+
"dist/main.android.jsbundle"
14+
],
1115
"ios": [
1216
"dist/assets",
13-
"dist/main.jsbundle"
17+
"dist/main.ios.jsbundle"
1418
],
1519
"macos": [
1620
"dist/assets",
17-
"dist/main.jsbundle"
18-
],
19-
"android": [
20-
"dist/res",
21-
"dist/main.jsbundle"
21+
"dist/main.macos.jsbundle"
2222
]
2323
}
2424
}

example/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
"version": "0.0.1",
44
"private": true,
55
"scripts": {
6-
"build:android": "mkdirp dist/res && react-native bundle --entry-file index.js --platform android --dev true --bundle-output dist/main.jsbundle --assets-dest dist/res --reset-cache",
7-
"build:ios": "mkdirp dist && react-native bundle --entry-file index.js --platform ios --dev true --bundle-output dist/main.jsbundle --assets-dest dist --reset-cache",
8-
"build:macos": "mkdirp dist && react-native bundle --entry-file index.js --platform macos --dev true --bundle-output dist/main.jsbundle --assets-dest dist --reset-cache --config=metro.config.macos.js",
6+
"build:android": "mkdirp dist/res && react-native bundle --entry-file index.js --platform android --dev true --bundle-output dist/main.android.jsbundle --assets-dest dist/res --reset-cache",
7+
"build:ios": "mkdirp dist && react-native bundle --entry-file index.js --platform ios --dev true --bundle-output dist/main.ios.jsbundle --assets-dest dist --reset-cache",
8+
"build:macos": "mkdirp dist && react-native bundle --entry-file index.js --platform macos --dev true --bundle-output dist/main.macos.jsbundle --assets-dest dist --reset-cache --config=metro.config.macos.js",
99
"start": "react-native start",
1010
"start:macos": "react-native start --config=metro.config.macos.js"
1111
},

plopfile.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,11 @@ module.exports = (plop) => {
7777
displayName: name,
7878
},
7979
],
80-
resources: ["dist/assets", "dist/main.jsbundle", "dist/res"],
80+
resources: {
81+
android: ["dist/res", "dist/main.android.jsbundle"],
82+
ios: ["dist/assets", "dist/main.ios.jsbundle"],
83+
macos: ["dist/assets", "dist/main.macos.jsbundle"],
84+
},
8185
}),
8286
},
8387
{
@@ -114,19 +118,19 @@ module.exports = (plop) => {
114118
...(!exclusive || platforms === "android"
115119
? {
116120
"build:android":
117-
"mkdirp dist/res && react-native bundle --entry-file index.js --platform android --dev true --bundle-output dist/main.jsbundle --assets-dest dist/res --reset-cache",
121+
"mkdirp dist/res && react-native bundle --entry-file index.js --platform android --dev true --bundle-output dist/main.android.jsbundle --assets-dest dist/res --reset-cache",
118122
}
119123
: undefined),
120124
...(!exclusive || platforms === "ios"
121125
? {
122126
"build:ios":
123-
"mkdirp dist && react-native bundle --entry-file index.js --platform ios --dev true --bundle-output dist/main.jsbundle --assets-dest dist --reset-cache",
127+
"mkdirp dist && react-native bundle --entry-file index.js --platform ios --dev true --bundle-output dist/main.ios.jsbundle --assets-dest dist --reset-cache",
124128
}
125129
: undefined),
126130
...(!exclusive || platforms === "macos"
127131
? {
128132
"build:macos":
129-
"mkdirp dist && react-native bundle --entry-file index.js --platform macos --dev true --bundle-output dist/main.jsbundle --assets-dest dist --reset-cache --config=metro.config.macos.js",
133+
"mkdirp dist && react-native bundle --entry-file index.js --platform macos --dev true --bundle-output dist/main.macos.jsbundle --assets-dest dist --reset-cache --config=metro.config.macos.js",
130134
"start:macos":
131135
"react-native start --config=metro.config.macos.js",
132136
}

0 commit comments

Comments
 (0)