If we failed to get a default profile, fail the settings load (#1343)

DHowett · web-flow · commit 66cb7c4b58b0 · 2019-06-20T11:20:49.000-07:00
This stops the crash in #1318.
diff --git a/src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp b/src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp
@@ -65,6 +65,11 @@ std::unique_ptr<CascadiaSettings> CascadiaSettings::LoadAll(const bool saveOnLoa
         }
         resultPtr = FromJson(root);
 
+        if (resultPtr->GlobalSettings().GetDefaultProfile() == GUID{})
+        {
+            throw winrt::hresult_invalid_argument();
+        }
+
         if (saveOnLoad)
         {
             // Logically compare the json we've parsed from the file to what

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,11 @@ std::unique_ptr<CascadiaSettings> CascadiaSettings::LoadAll(const bool saveOnLoa`
`65`	`65`	`}`
`66`	`66`	`resultPtr = FromJson(root);`
`67`	`67`
	`68`	`+ if (resultPtr->GlobalSettings().GetDefaultProfile() == GUID{})`
	`69`	`+ {`
	`70`	`+ throw winrt::hresult_invalid_argument();`
	`71`	`+ }`
	`72`	`+`
`68`	`73`	`if (saveOnLoad)`
`69`	`74`	`{`
`70`	`75`	`// Logically compare the json we've parsed from the file to what`