Skip to content

Commit f2a6918

Browse files
zadjii-msftDHowett
authored andcommitted
[1.14] Update the MUX package to 2.7.3 (#13761)
Does two things: * the first two commits: shakes up the way we reference MUX in our projects so we can actually just ```xml <PropertyGroup Label="NuGet Dependencies"> <TerminalMUX>true</TerminalMUX> </PropertyGroup> ``` Like every other dependency we have * the last commit: update to MUX.2.7.3 This is the 1.14 PR, which should be appropriately cherry-picked through to `release-1.15` and `main` (cherry picked from commit a277b56) Service-Card-Id: 85036583 Service-Version: 1.15
1 parent 76daf71 commit f2a6918

File tree

11 files changed

+22
-56
lines changed

11 files changed

+22
-56
lines changed

build/packages.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@
44
<package id="Microsoft.Taef" version="10.60.210621002" targetFramework="native" />
55
<package id="Microsoft.Internal.PGO-Helpers.Cpp" version="0.2.34" targetFramework="native" />
66
<!-- This cannot be included in another project that depends on XAML (as it would be a duplicate package ID) -->
7-
<package id="Microsoft.UI.Xaml" version="2.7.0" targetFramework="native" />
7+
<package id="Microsoft.UI.Xaml" version="2.7.3" targetFramework="native" />
88
</packages>

common.openconsole.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@
1818
1919
This version should be tracked in all project packages.config files for projects that depend on Xaml.
2020
-->
21-
<TerminalMUXVersion>2.7.2-prerelease.220406002</TerminalMUXVersion>
21+
<TerminalMUXVersion>2.7.3-prerelease.220816001</TerminalMUXVersion>
2222
<!--
2323
For the Windows 11-specific build, we're targeting the public version of Microsoft.UI.Xaml.
2424
This version emits a package dependency instead of embedding the dependency in our own package.
2525
2626
This version should be tracked in build/packages.config.
2727
-->
28-
<TerminalMUXVersion Condition="'$(TerminalTargetWindowsVersion)'=='Win11'">2.7.1</TerminalMUXVersion>
28+
<TerminalMUXVersion Condition="'$(TerminalTargetWindowsVersion)'=='Win11'">2.7.3</TerminalMUXVersion>
2929
</PropertyGroup>
3030

3131
</Project>

dep/nuget/packages.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<package id="Microsoft.VCRTForwarders.140" version="1.0.4" targetFramework="native" />
1111
<package id="Microsoft.Internal.Windows.Terminal.ThemeHelpers" version="0.6.220404001" targetFramework="native" />
1212
<package id="Microsoft.VisualStudio.Setup.Configuration.Native" version="2.3.2262" targetFramework="native" developmentDependency="true" />
13-
<package id="Microsoft.UI.Xaml" version="2.7.2-prerelease.220406002" targetFramework="native" />
13+
<package id="Microsoft.UI.Xaml" version="2.7.3-prerelease.220816001" targetFramework="native" />
1414
<package id="Microsoft.Windows.ImplementationLibrary" version="1.0.220201.1" targetFramework="native" developmentDependency="true" />
1515

1616
<!-- Managed packages -->

src/cascadia/CascadiaPackage/CascadiaPackage.wapproj

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<Import Project="..\..\..\common.openconsole.props" Condition="'$(OpenConsoleDir)'==''" />
4+
5+
<PropertyGroup Label="NuGet Dependencies">
6+
<TerminalMUX>true</TerminalMUX>
7+
</PropertyGroup>
48
<Import Project="$(OpenConsoleDir)src\wap-common.build.pre.props" />
9+
<Import Project="$(OpenConsoleDir)src\common.nugetversions.props" />
510
<PropertyGroup Label="Configuration">
611
<!--
712
These two properties are very important!
@@ -164,13 +169,7 @@
164169
</Target>
165170

166171
<!-- This is required to get the package dependency in the AppXManifest. -->
167-
<Import Project="..\..\..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets" Condition="Exists('..\..\..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" />
168-
<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
169-
<PropertyGroup>
170-
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
171-
</PropertyGroup>
172-
<Error Condition="!Exists('..\..\..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets'))" />
173-
</Target>
172+
<Import Project="$(OpenConsoleDir)src\common.nugetversions.targets" />
174173

175174
<Import Project="$(SolutionDir)build\rules\CollectWildcardResources.targets" />
176175
</Project>

src/cascadia/TerminalApp/TerminalAppLib.vcxproj

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
<PropertyGroup Label="NuGet Dependencies">
2121
<TerminalCppWinrt>true</TerminalCppWinrt>
2222
<TerminalXamlApplicationToolkit>true</TerminalXamlApplicationToolkit>
23+
<TerminalMUX>true</TerminalMUX>
2324
</PropertyGroup>
2425
<Import Project="..\..\..\common.openconsole.props" Condition="'$(OpenConsoleDir)'==''" />
2526
<Import Project="$(OpenConsoleDir)src\common.nugetversions.props" />
@@ -407,13 +408,6 @@
407408
<!-- This -must- go after cppwinrt.build.post.props because that includes many VS-provided props including appcontainer.common.props, which stomps on what cppwinrt.targets did. -->
408409
<Import Project="$(OpenConsoleDir)src\common.nugetversions.targets" />
409410

410-
<Import Project="..\..\..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets" Condition="Exists('..\..\..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" />
411-
<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
412-
<PropertyGroup>
413-
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
414-
</PropertyGroup>
415-
<Error Condition="!Exists('$(OpenConsoleDir)\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" Text="$([System.String]::Format('$(ErrorText)', '$(OpenConsoleDir)\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets'))" />
416-
</Target>
417411
<!--
418412
By default, the PRI file will contain resource paths beginning with the
419413
project name. Since we enabled XBF embedding, this *also* includes App.xbf.

src/cascadia/TerminalApp/dll/TerminalApp.vcxproj

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<PropertyGroup Label="NuGet Dependencies">
1616
<TerminalCppWinrt>true</TerminalCppWinrt>
1717
<TerminalXamlApplicationToolkit>true</TerminalXamlApplicationToolkit>
18+
<TerminalMUX>true</TerminalMUX>
1819
</PropertyGroup>
1920
<Import Project="..\..\..\..\common.openconsole.props" Condition="'$(OpenConsoleDir)'==''" />
2021
<Import Project="$(OpenConsoleDir)src\common.nugetversions.props" />
@@ -92,14 +93,6 @@
9293
</Reference>
9394
</ItemGroup>
9495

95-
<Import Project="$(OpenConsoleDir)packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets" Condition="Exists('$(OpenConsoleDir)packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" />
96-
<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
97-
<PropertyGroup>
98-
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
99-
</PropertyGroup>
100-
<Error Condition="!Exists('$(OpenConsoleDir)\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" Text="$([System.String]::Format('$(ErrorText)', '$(OpenConsoleDir)\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets'))" />
101-
</Target>
102-
10396
<ItemDefinitionGroup>
10497
<ClCompile>
10598
<AdditionalIncludeDirectories>$(OpenConsoleDir)\dep\jsoncpp\json;%(AdditionalIncludeDirectories);</AdditionalIncludeDirectories>

src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
</PropertyGroup>
3535
<PropertyGroup Label="NuGet Dependencies">
3636
<TerminalCppWinrt>true</TerminalCppWinrt>
37+
<TerminalMUX>true</TerminalMUX>
3738
</PropertyGroup>
3839
<Import Project="..\..\..\common.openconsole.props" Condition="'$(OpenConsoleDir)'==''" />
3940
<Import Project="$(OpenConsoleDir)src\common.nugetversions.props" />
@@ -353,12 +354,5 @@
353354
<!-- This -must- go after cppwinrt.build.post.props because that includes many VS-provided props including appcontainer.common.props, which stomps on what cppwinrt.targets did. -->
354355
<Import Project="$(OpenConsoleDir)src\common.nugetversions.targets" />
355356

356-
<Import Project="..\..\..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets" Condition="Exists('..\..\..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" />
357-
<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
358-
<PropertyGroup>
359-
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
360-
</PropertyGroup>
361-
<Error Condition="!Exists('$(OpenConsoleDir)\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" Text="$([System.String]::Format('$(ErrorText)', '$(OpenConsoleDir)\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets'))" />
362-
</Target>
363357
<Import Project="$(SolutionDir)build\rules\CollectWildcardResources.targets" />
364358
</Project>

src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
<PropertyGroup Label="NuGet Dependencies">
1515
<TerminalCppWinrt>true</TerminalCppWinrt>
1616
<TerminalVisualStudioSetup>true</TerminalVisualStudioSetup>
17+
<TerminalMUX>true</TerminalMUX>
1718
</PropertyGroup>
1819
<Import Project="..\..\..\common.openconsole.props" Condition="'$(OpenConsoleDir)'==''" />
1920
<Import Project="$(OpenConsoleDir)src\common.nugetversions.props" />
@@ -274,13 +275,6 @@
274275
<Import Project="$(OpenConsoleDir)src\cppwinrt.build.post.props" />
275276
<Import Project="$(OpenConsoleDir)src\common.nugetversions.targets" />
276277

277-
<Import Project="..\..\..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets" Condition="Exists('..\..\..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" />
278-
<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
279-
<PropertyGroup>
280-
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
281-
</PropertyGroup>
282-
<Error Condition="!Exists('$(OpenConsoleDir)\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" Text="$([System.String]::Format('$(ErrorText)', '$(OpenConsoleDir)\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets'))" />
283-
</Target>
284278
<!-- This target will take our defaults.json and stamp it into a .h file that
285279
we can include in the code directly. This way, we don't need to worry about
286280
failing to load the default settings at runtime. -->

src/cascadia/TerminalSettingsModel/dll/Microsoft.Terminal.Settings.Model.vcxproj

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
</PropertyGroup>
1515
<PropertyGroup Label="NuGet Dependencies">
1616
<TerminalCppWinrt>true</TerminalCppWinrt>
17+
<TerminalMUX>true</TerminalMUX>
1718
</PropertyGroup>
1819
<Import Project="..\..\..\..\common.openconsole.props" Condition="'$(OpenConsoleDir)'==''" />
1920
<Import Project="$(OpenConsoleDir)src\common.nugetversions.props" />
@@ -105,14 +106,6 @@
105106
</Reference>
106107
</ItemGroup>
107108

108-
<Import Project="$(OpenConsoleDir)packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets" Condition="Exists('$(OpenConsoleDir)packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" />
109-
<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
110-
<PropertyGroup>
111-
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
112-
</PropertyGroup>
113-
<Error Condition="!Exists('$(OpenConsoleDir)\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" Text="$([System.String]::Format('$(ErrorText)', '$(OpenConsoleDir)\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets'))" />
114-
</Target>
115-
116109
<ItemDefinitionGroup>
117110
<ClCompile>
118111
<AdditionalIncludeDirectories>$(OpenConsoleDir)\dep\jsoncpp\json;%(AdditionalIncludeDirectories);</AdditionalIncludeDirectories>

src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
<TerminalXamlApplicationToolkit>true</TerminalXamlApplicationToolkit>
2222
<TerminalVCRTForwarders>true</TerminalVCRTForwarders>
2323
<TerminalThemeHelpers>true</TerminalThemeHelpers>
24+
<TerminalMUX>true</TerminalMUX>
2425
</PropertyGroup>
2526

2627
<Import Project="..\..\..\common.openconsole.props" Condition="'$(OpenConsoleDir)'==''" />
@@ -141,14 +142,6 @@
141142

142143
<Import Project="$(OpenConsoleDir)src\cppwinrt.build.post.props" />
143144

144-
<Import Project="..\..\..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets" Condition="Exists('..\..\..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" />
145-
<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
146-
<PropertyGroup>
147-
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
148-
</PropertyGroup>
149-
<Error Condition="!Exists('..\..\..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets'))" />
150-
</Target>
151-
152145
<!-- Override GetPackagingOutputs to roll up all our dependencies.
153146
This ensures that when the WAP packaging project asks what files go into
154147
the package, we tell it.

src/common.nugetversions.targets

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,9 @@
5858
<!-- VisualStudioSetup -->
5959
<Import Project="$(MSBuildThisFileDirectory)..\packages\Microsoft.VisualStudio.Setup.Configuration.Native.2.3.2262\build\native\Microsoft.VisualStudio.Setup.Configuration.Native.targets" Condition="'$(TerminalVisualStudioSetup)' == 'true' and Exists('$(MSBuildThisFileDirectory)..\packages\Microsoft.VisualStudio.Setup.Configuration.Native.2.3.2262\build\native\Microsoft.VisualStudio.Setup.Configuration.Native.targets')" />
6060

61+
<!-- WinUI (which depends on WebView2 as of 2.8.0) -->
62+
<Import Project="$(MSBuildThisFileDirectory)..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets" Condition="'$(TerminalMUX)' == 'true' and Exists('$(MSBuildThisFileDirectory)..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" />
63+
6164
<!-- WIL (so widely used that this one does not have a TerminalWIL opt-in property; it is automatic) -->
6265
<Import Project="$(MSBuildThisFileDirectory)..\packages\Microsoft.Windows.ImplementationLibrary.1.0.220201.1\build\native\Microsoft.Windows.ImplementationLibrary.targets" Condition="Exists('$(MSBuildThisFileDirectory)..\packages\Microsoft.Windows.ImplementationLibrary.1.0.220201.1\build\native\Microsoft.Windows.ImplementationLibrary.targets')" />
6366

@@ -95,6 +98,9 @@
9598
<!-- VisualStudioSetup -->
9699
<Error Condition="'$(TerminalVisualStudioSetup)' == 'true' AND !Exists('$(MSBuildThisFileDirectory)..\packages\Microsoft.VisualStudio.Setup.Configuration.Native.2.3.2262\build\native\Microsoft.VisualStudio.Setup.Configuration.Native.targets')" Text="$([System.String]::Format('$(ErrorText)', '$(MSBuildThisFileDirectory)..\packages\Microsoft.VisualStudio.Setup.Configuration.Native.2.3.2262\build\native\Microsoft.VisualStudio.Setup.Configuration.Native.targets'))" />
97100

101+
<!-- WinUI (which depends on WebView2 as of 2.8.0) -->
102+
<Error Condition="'$(TerminalMUX)' == 'true' AND !Exists('$(MSBuildThisFileDirectory)..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets')" Text="$([System.String]::Format('$(ErrorText)', '$(MSBuildThisFileDirectory)..\packages\Microsoft.UI.Xaml.$(TerminalMUXVersion)\build\native\Microsoft.UI.Xaml.targets'))" />
103+
98104
<!-- WIL (so widely used that this one does not have a TerminalWIL opt-in property; it is automatic) -->
99105
<Error Condition="!Exists('$(MSBuildThisFileDirectory)..\packages\Microsoft.Windows.ImplementationLibrary.1.0.220201.1\build\native\Microsoft.Windows.ImplementationLibrary.targets')" Text="$([System.String]::Format('$(ErrorText)', '$(MSBuildThisFileDirectory)..\packages\Microsoft.Windows.ImplementationLibrary.1.0.220201.1\build\native\Microsoft.Windows.ImplementationLibrary.targets'))" />
100106

0 commit comments

Comments
 (0)