Port "Fixed nullish coalesce operator's precedence"

Author: Andarist

internal/ast/precedence.go

@@ -43,6 +43,10 @@ const (
 	//     ShortCircuitExpression
 	//     ShortCircuitExpression `?` AssignmentExpression `:` AssignmentExpression
 	OperatorPrecedenceConditional
+	// LogicalORExpression:
+	//     LogicalANDExpression
+	//     LogicalORExpression `||` LogicalANDExpression
+	OperatorPrecedenceLogicalOR
 	// ShortCircuitExpression:
 	//     LogicalORExpression
 	//     CoalesceExpression
@@ -52,10 +56,6 @@ const (
 	//     CoalesceExpression
 	//     BitwiseORExpression
 	OperatorPrecedenceCoalesce
-	// LogicalORExpression:
-	//     LogicalANDExpression
-	//     LogicalORExpression `||` LogicalANDExpression
-	OperatorPrecedenceLogicalOR
 	// LogicalANDExpression:
 	//     BitwiseORExpression
 	//     LogicalANDExprerssion `&&` BitwiseORExpression

internal/checker/checker.go

@@ -12400,11 +12400,22 @@ func (c *Checker) getSyntacticTruthySemantics(node *ast.Node) PredicateSemantics
 }
 
 func (c *Checker) checkNullishCoalesceOperands(left *ast.Node, right *ast.Node) {
-	if ast.IsBinaryExpression(left) && ast.IsLogicalBinaryOperator(left.AsBinaryExpression().OperatorToken.Kind) {
-		c.grammarErrorOnNode(left, diagnostics.X_0_and_1_operations_cannot_be_mixed_without_parentheses, scanner.TokenToString(left.AsBinaryExpression().OperatorToken.Kind), scanner.TokenToString(ast.KindQuestionQuestionToken))
-	}
-	if ast.IsBinaryExpression(right) && ast.IsLogicalBinaryOperator(right.AsBinaryExpression().OperatorToken.Kind) {
-		c.grammarErrorOnNode(right, diagnostics.X_0_and_1_operations_cannot_be_mixed_without_parentheses, scanner.TokenToString(right.AsBinaryExpression().OperatorToken.Kind), scanner.TokenToString(ast.KindQuestionQuestionToken))
+	if ast.IsBinaryExpression(left.Parent.Parent) {
+		operatorToken := left.Parent.Parent.AsBinaryExpression().OperatorToken
+		left := left.Parent.Parent.AsBinaryExpression().Left
+		if ast.IsBinaryExpression(left) && operatorToken.Kind == ast.KindBarBarToken {
+			c.grammarErrorOnNode(left, diagnostics.X_0_and_1_operations_cannot_be_mixed_without_parentheses, scanner.TokenToString(ast.KindQuestionQuestionToken), scanner.TokenToString(operatorToken.Kind))	
+		}
+	} else if ast.IsBinaryExpression(left) {
+		operatorToken := left.AsBinaryExpression().OperatorToken
+		if operatorToken.Kind == ast.KindBarBarToken || operatorToken.Kind == ast.KindAmpersandAmpersandToken {
+			c.grammarErrorOnNode(left, diagnostics.X_0_and_1_operations_cannot_be_mixed_without_parentheses, scanner.TokenToString(operatorToken.Kind), scanner.TokenToString(ast.KindQuestionQuestionToken))	
+		}
+	} else if ast.IsBinaryExpression(right) {
+		operatorToken := right.AsBinaryExpression().OperatorToken
+		if operatorToken.Kind == ast.KindAmpersandAmpersandToken {
+			c.grammarErrorOnNode(right, diagnostics.X_0_and_1_operations_cannot_be_mixed_without_parentheses, scanner.TokenToString(ast.KindQuestionQuestionToken), scanner.TokenToString(operatorToken.Kind))	
+		}
 	}
 	leftTarget := ast.SkipOuterExpressions(left, ast.OEKAll)
 	nullishSemantics := c.getSyntacticNullishnessSemantics(leftTarget)