fix expando prop type and keyword generated alias names

Author: a-tarasyuk

internal/transformers/declarations/transform.go

@@ -1836,7 +1836,6 @@ func (tx *DeclarationTransformer) visitExpressionStatement(node *ast.ExpressionS
 
 func (tx *DeclarationTransformer) transformExpandoAssignment(node *ast.BinaryExpression) *ast.Node {
 	left := node.Left
-	right := node.Right
 
 	if ast.IsElementAccessExpression(left) {
 		return nil
@@ -1874,13 +1873,13 @@ func (tx *DeclarationTransformer) transformExpandoAssignment(node *ast.BinaryExp
 
 	saveDiag := tx.state.getSymbolAccessibilityDiagnostic
 	tx.state.getSymbolAccessibilityDiagnostic = createGetSymbolAccessibilityDiagnosticForNode(node.AsNode())
-	t := tx.resolver.CreateTypeOfExpression(tx.EmitContext(), right, synthesizedNamespace, declarationEmitNodeBuilderFlags, declarationEmitInternalNodeBuilderFlags|nodebuilder.InternalFlagsNoSyntacticPrinter, tx.tracker)
+	t := tx.resolver.CreateTypeOfExpression(tx.EmitContext(), left, synthesizedNamespace, declarationEmitNodeBuilderFlags, declarationEmitInternalNodeBuilderFlags|nodebuilder.InternalFlagsNoSyntacticPrinter, tx.tracker)
 	tx.state.getSymbolAccessibilityDiagnostic = saveDiag
 
 	nameToken := scanner.StringToToken(left.Name().Text())
 	isNonContextualKeywordName := ast.IsNonContextualKeyword(nameToken)
 
-	exportName := core.IfElse(isNonContextualKeywordName, tx.Factory().NewGeneratedNameForNode(left.Name()), tx.Factory().NewIdentifier(left.Name().Text()))
+	exportName := core.IfElse(isNonContextualKeywordName, tx.Factory().NewGeneratedNameForNode(left), tx.Factory().NewIdentifier(left.Name().Text()))
 	statements := []*ast.Statement{
 		tx.Factory().NewVariableStatement(
 			nil, /*modifiers*/

testdata/baselines/reference/submodule/compiler/declarationEmitFunctionDuplicateNamespace.js

@@ -21,5 +21,5 @@ f.x = 2;
 declare function f(a: 0): 0;
 declare function f(a: 1): 1;
 declare namespace f {
-    const x: 2;
+    const x: number;
 }

testdata/baselines/reference/submodule/compiler/declarationEmitFunctionDuplicateNamespace.js.diff

@@ -5,5 +5,5 @@
  declare function f(a: 1): 1;
  declare namespace f {
 -    var x: number;
-+    const x: 2;
++    const x: number;
  }

testdata/baselines/reference/submodule/compiler/declarationEmitFunctionKeywordProp.js

@@ -26,21 +26,21 @@ baz.normal = false;
 //// [declarationEmitFunctionKeywordProp.d.ts]
 declare function foo(): void;
 declare namespace foo {
-    const null_1: true;
-    export { null_1 as null };
+    const _a: boolean;
+    export { _a as null };
 }
 declare function bar(): void;
 declare namespace bar {
-    const async: true;
+    const async: boolean;
 }
 declare namespace bar {
-    const normal: false;
+    const normal: boolean;
 }
 declare function baz(): void;
 declare namespace baz {
-    const class_1: true;
-    export { class_1 as class };
+    const _b: boolean;
+    export { _b as class };
 }
 declare namespace baz {
-    const normal: false;
+    const normal: boolean;
 }

testdata/baselines/reference/submodule/compiler/declarationEmitFunctionKeywordProp.js.diff

@@ -5,27 +5,26 @@
  declare function foo(): void;
  declare namespace foo {
 -    var _a: boolean;
--    export { _a as null };
-+    const null_1: true;
-+    export { null_1 as null };
++    const _a: boolean;
+     export { _a as null };
  }
  declare function bar(): void;
  declare namespace bar {
 -    var async: boolean;
 -    var normal: boolean;
-+    const async: true;
++    const async: boolean;
 +}
 +declare namespace bar {
-+    const normal: false;
++    const normal: boolean;
  }
  declare function baz(): void;
  declare namespace baz {
 -    var _a: boolean;
 -    export var normal: boolean;
 -    export { _a as class };
-+    const class_1: true;
-+    export { class_1 as class };
++    const _b: boolean;
++    export { _b as class };
 +}
 +declare namespace baz {
-+    const normal: false;
++    const normal: boolean;
  }

testdata/baselines/reference/submodule/compiler/declarationEmitLateBoundAssignments.js

@@ -37,5 +37,5 @@ const a = foo[dashStrMem];
 //// [declarationEmitLateBoundAssignments.d.ts]
 export declare function foo(): void;
 export declare namespace foo {
-    const bar: 12;
+    const bar: number;
 }

testdata/baselines/reference/submodule/compiler/declarationEmitLateBoundAssignments.js.diff

@@ -6,5 +6,5 @@
  export declare namespace foo {
 -    var bar: number;
 -    var strMemName: string;
-+    const bar: 12;
++    const bar: number;
  }

testdata/baselines/reference/submodule/compiler/declarationEmitLateBoundJSAssignments.js

@@ -27,5 +27,5 @@ const a = foo[dashStrMem];
 //// [file.d.ts]
 export declare function foo(): void;
 export declare namespace foo {
-    const bar: 12;
+    const bar: number;
 }

testdata/baselines/reference/submodule/compiler/declarationEmitLateBoundJSAssignments.js.diff

@@ -10,5 +10,5 @@
 -    let strMemName: string;
 +export declare function foo(): void;
 +export declare namespace foo {
-+    const bar: 12;
++    const bar: number;
  }

testdata/baselines/reference/submodule/compiler/expandoFunctionBlockShadowing.js

@@ -46,5 +46,5 @@ if (Math.random()) {
 export declare function X(): void;
 export declare function Y(): void;
 export declare namespace Y {
-    const test: "foo";
+    const test: string;
 }