[at-spi2-core] Build error on x64-linux: missing xtst dependency

[jefftrull]

While using 2024.10.21 in GitHub Actions I get a strange Python error complaining of a missing xtst dependency. This isn't anything I use, and adding libxtst to my vcpkg.json doesn't help. The log is very long of course but the bit preceding the error looks like this:

Calling CMake (['/usr/local/bin/cmake']) in /home/runner/work/EDASkel/EDASkel/vcpkg/buildtrees/at-spi2-core/x64-linux-dbg/meson-private/cmake_xtst with:
    - "--trace-expand"
    - "--trace-format=json-v1"
    - "--no-warn-unused-cli"
    - "--trace-redirect=cmake_trace.txt"
    - "-DCMAKE_TOOLCHAIN_FILE=/home/runner/work/EDASkel/EDASkel/vcpkg/buildtrees/at-spi2-core/x64-linux-dbg/meson-private/cmake_xtst/CMakeMesonToolchainFile.cmake"
    - "."
    - "-DCMAKE_PREFIX_PATH=/home/runner/work/EDASkel/EDASkel/969f6665-88a2-4c98-938e-ca9259871fec/vcpkg_installed/x64-linux/debug;/home/runner/work/EDASkel/EDASkel/969f6665-88a2-4c98-938e-ca9259871fec/vcpkg_installed/x64-linux"
    -- Module search paths:    ['/', '/home/runner/work/EDASkel/EDASkel/969f6665-88a2-4c98-938e-ca9259871fec/vcpkg_installed/x64-linux', '/home/runner/work/EDASkel/EDASkel/969f6665-88a2-4c98-938e-ca9259871fec/vcpkg_installed/x64-linux/debug', '/opt', '/usr', '/usr/local']
    -- CMake root:             /usr/local/share/cmake-3.30
    -- CMake architectures:    ['x86_64-linux-gnu']
    -- CMake lib search paths: ['lib', 'lib32', 'lib64', 'libx32', 'share', '', 'lib/x86_64-linux-gnu']
  Preliminary CMake check failed. Aborting.
  Run-time dependency xtst found: NO (tried pkgconfig and cmake)
  
  ../src/ORE_2_44_1-fa40e2a5ad.clean/meson.build:74:16: ERROR: Dependency "xtst" not found, tried pkgconfig and cmake
  


[LogCollection][End]File:'/home/runner/work/EDASkel/EDASkel/vcpkg/buildtrees/at-spi2-core/config-x64-linux-dbg-out.log'.
Warning: [LogCollection][Warn]File not found:'Command failed: /usr/bin/python3 -I /home/runner/work/EDASkel/EDASkel/vcpkg/downloads/tools/meson-1.5.2-dd4692/meson.py setup -Dintrospection=no --backend ninja --wrap-mode nodownload -Doptimization=plain --native /home/runner/work/EDASkel/EDASkel/vcpkg/buildtrees/at-spi2-core/meson-x64-linux-dbg.log'.
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
Error:     Command failed: /usr/bin/python3 -I /home/runner/work/EDASkel/EDASkel/vcpkg/downloads/tools/meson-1.5.2-dd4692/meson.py setup -Dintrospection=no --backend ninja --wrap-mode nodownload -Doptimization=plain --native /home/runner/work/EDASkel/EDASkel/vcpkg/buildtrees/at-spi2-core/meson-x64-linux-dbg.log --libdir lib --pkgconfig.relocatable -Ddebug=true --prefix /home/runner/work/EDASkel/EDASkel/vcpkg/packages/at-spi2-core_x64-linux/debug --includedir ../include --pkg-config-path ['/home/runner/work/EDASkel/EDASkel/969f6665-88a2-4c98-938e-ca9259871fec/vcpkg_installed/x64-linux/debug/lib/pkgconfig','/home/runner/work/EDASkel/EDASkel/969f6665-88a2-4c98-938e-ca9259871fec/vcpkg_installed/x64-linux/share/pkgconfig'] -Dcmake_prefix_path=['/home/runner/work/EDASkel/EDASkel/969f6665-88a2-4c98-938e-ca9259871fec/vcpkg_installed/x64-linux/debug','/home/runner/work/EDASkel/EDASkel/969f6665-88a2-4c98-938e-ca9259871fec/vcpkg_installed/x64-linux'] /home/runner/work/EDASkel/EDASkel/vcpkg/buildtrees/at-spi2-core/src/ORE_2_44_1-fa40e2a5ad.clean
    Working Directory: /home/runner/work/EDASkel/EDASkel/vcpkg/buildtrees/at-spi2-core/x64-linux-dbg
    Error code: 1
    See logs for more information:
      /home/runner/work/EDASkel/EDASkel/vcpkg/buildtrees/at-spi2-core/config-x64-linux-dbg-meson-log.txt.log
      /home/runner/work/EDASkel/EDASkel/vcpkg/buildtrees/at-spi2-core/config-x64-linux-dbg-out.log

Call Stack (most recent call first):
  /home/runner/work/EDASkel/EDASkel/969f6665-88a2-4c98-938e-ca9259871fec/vcpkg_installed/x64-linux/share/vcpkg-tool-meson/vcpkg_configure_meson.cmake:468 (vcpkg_execute_required_process)
  ports/at-spi2-core/portfile.cmake:13 (vcpkg_configure_meson)
  scripts/ports.cmake:192 (include)


error: building at-spi2-core:x64-linux failed with: BUILD_FAILED

The following text in the log file encourages me to file a bug, so I have. Should I use a different version? Is there another workaround? Thanks.

[jefftrull]

The repo in question is https://github.com/jefftrull/EDASkel/tree/initial-CI

[dg0yt]

Run-time dependency xtst found: NO (tried pkgconfig and cmake)

You need a system dev package for xtst.

[jefftrull]

Thank you. Is there no other way for the package that needs this to arrange it? I'm surprised there is no dependency concept that could avoid this.

[dg0yt]

X libraries are generally considered to be provided by the linux system at the moment. And there is no dependency concept to handle this, except printing messages. These messages tend to be incomplete, unaware of actual installation state, and not covering non-mainstream distros.
The best indication of required system packages ist the CI image configuration starting at
https://github.com/microsoft/vcpkg/blob/master/scripts/azure-pipelines/linux/provision-image.sh#L39

[dg0yt]

FTR at-spi2-core prints to the console:

-- at-spi2-core currently requires the following libraries from the system package manager:
    libxi-dev
    libxtst-dev

These can be installed on Ubuntu systems via apt-get install libxi-dev libxtst-dev