-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[curl] Please allow to curl build against LibreSSL (=OpenSSL fork) #42623
Comments
(Community feedback:) You can do that already: If you do not want multi-ssl, you can try Repeating the points from #42622 (comment): ATM port curl is built on multi-ssl support, and the incompatibility between HTTP3 and multi-ssl is known to contributors and maintainers.
AFAICS a general switch of the default ssl lib is probably too risky due to the impact on existing user projects, apart from the number of changes needed to ports in vcpkg. |
You are right. I'm sorry for this oversight. I have to come back to the topics of "alternatives". ATM vcpkg doesn't allow to install the ports openssl and libressl at the same time. That's why port libressl is normally skipped in vcpkg CI. And that's why port libressl was poorly maintained in the past (and maybe still is). In september I submitted a PR which improved the quality of port libressl, with temporary testing in vcpkg CI, including using libressl (instead of openssl) in curl: #41083. This PR (temporarily) applied a variation of the accepted (but possibly incovenient) pattern of dealing with alternatives: It (temporarily) turned port openssl in an empty artifact, doing nothing but pulling in libressl via dependency. This is the first commit in the series: 039ec7f (reverted by the last commit). Basically this is how you can build curl with libressl instead of openssl now: Provide an empty overlay port for openssl which depends on libressl.
|
All good, happens to the best of us! :)
I appreciate the deep dive. I wasn't able to do more than glance at what you wrote today, but I plan to give it my full attention tomorrow. I shall report back! |
🎉 |
Updating to say, the LibreSSL overlay introduces a major issue where (specifically) WolfSSL doesn't function at all, despite not displaying any build warnings or crashing during run. Sending any The other 4 SSLs (GnuTLS/mbedTLS/LibreSSL/Schannel) do work as expected in this configuration. That said, I've reverted to building with OpenSSL (+the rest) for the time being. |
Since updating vcpkg today, rebuilding with the overlay has not resulted in the WolfSSL issue detailed above. I don't know if the change relates to anything you've pushed or if my local cache was just bugged, but it's now working. I'll take it for now, lol. |
Thanks for posting the updates from the hot tests. Without feedback, it is often difficult to assess relevance and maturity of port features. |
Is your feature request related to a problem? Please describe.
For a number of reasons, @bagder has begun to ship curl's "default" Windows binaries built against LibreSSL instead of OpenSSL. Please allow vcpkg's curl to build against LibreSSL, as well.
Proposed solution
Please enable building against LibreSSL.
Describe alternatives you've considered
No response
Additional context
Despite being the namesake fork, OpenSSL appears to be falling out of favor with curl development.
While I don't in any way speak for curl, the factors that support this insight are:
The text was updated successfully, but these errors were encountered: