refactor: simplify getLabel logic in PackageRootNode

mamilic · mamilic · commit f4b44d91a176 · 2024-10-21T13:19:30.000+02:00
diff --git a/src/views/packageRootNode.ts b/src/views/packageRootNode.ts
@@ -21,11 +21,8 @@ export class PackageRootNode extends DataNode {
     }
 
     public getLabel(): string {
-        if (this.getParent() instanceof ContainerNode) {
-            const parent = this.getParent() as ContainerNode;
-            if (parent.getContainerType() == ContainerType.Maven) {
-                return `${this._nodeData.metaData?.['maven.groupId']}:${this._nodeData.metaData?.['maven.artifactId']}:${this._nodeData.metaData?.['maven.version']}`;
-            }
+        if (this._nodeData.metaData?.['maven.groupId']) {
+            return `${this._nodeData.metaData?.['maven.groupId']}:${this._nodeData.metaData?.['maven.artifactId']}:${this._nodeData.metaData?.['maven.version']}`;
         }
         return this._nodeData.displayName ?? this._nodeData.name;
     }

Original file line number	Diff line number	Diff line change
`@@ -21,11 +21,8 @@ export class PackageRootNode extends DataNode {`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`public getLabel(): string {`
`24`		`- if (this.getParent() instanceof ContainerNode) {`
`25`		`- const parent = this.getParent() as ContainerNode;`
`26`		`- if (parent.getContainerType() == ContainerType.Maven) {`
`27`		- return `${this._nodeData.metaData?.['maven.groupId']}:${this._nodeData.metaData?.['maven.artifactId']}:${this._nodeData.metaData?.['maven.version']}`;
`28`		`- }`
	`24`	`+ if (this._nodeData.metaData?.['maven.groupId']) {`
	`25`	+ return `${this._nodeData.metaData?.['maven.groupId']}:${this._nodeData.metaData?.['maven.artifactId']}:${this._nodeData.metaData?.['maven.version']}`;
`29`	`26`	`}`
`30`	`27`	`return this._nodeData.displayName ?? this._nodeData.name;`
`31`	`28`	`}`