Skip to content

Commit 41c8021

Browse files
authored
fix: variables in bundled code with source maps aren't renamed properly (#2202)
Fixes #2201
1 parent 1942fd6 commit 41c8021

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

src/common/positions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export class Base1Position implements IPosition {
8383
}
8484

8585
/**
86-
* A position that starts a line 0 and column 1 (used by sourcemaps).
86+
* A position that starts a line 1 and column 0 (used by sourcemaps).
8787
*/
8888
export class Base01Position implements IPosition {
8989
declare readonly __isBase01: undefined;

src/common/sourceMaps/renameScopeAndSourceMap.ts

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export const extractScopeRenames = async (source: string, sourceMap: SourceMap)
3333
) => {
3434
// keep things as numbers for performance: number in upper bits (until MAX_SAFE_INTEGER),
3535
// column in lower 32 bits.
36-
const cacheKey = (generatedLineBase0 * 0x7fffffff) | generatedColumnBase0;
36+
const cacheKey = (generatedLineBase0 * 0x7fffffff) + generatedColumnBase0;
3737
if (usedMappings.has(cacheKey)) {
3838
return undefined;
3939
}
@@ -75,16 +75,10 @@ export const extractScopeRenames = async (source: string, sourceMap: SourceMap)
7575

7676
const generatedLineBase0 = i;
7777
const generatedColumnBase0 = mapping[0];
78-
if (
79-
generatedLineBase0 === node.range.begin.base0.lineNumber
80-
&& node.range.begin.base0.columnNumber > generatedColumnBase0
81-
) {
78+
if (generatedLineBase0 === start.lineNumber && start.columnNumber > generatedColumnBase0) {
8279
continue;
8380
}
84-
if (
85-
generatedLineBase0 === node.range.end.base0.lineNumber
86-
&& node.range.end.base0.columnNumber < generatedColumnBase0
87-
) {
81+
if (generatedLineBase0 === end.lineNumber && end.columnNumber < generatedColumnBase0) {
8882
continue;
8983
}
9084

0 commit comments

Comments
 (0)