Merge pull request #2191 from microsoft/connor4312/vscode-243409

fix: explicitly specify completion ranges

Author: connor4312

CHANGELOG.md

@@ -2,8 +2,9 @@
 
 This changelog records changes to stable releases since 1.50.2. "TBA" changes here may be available in the [nightly release](https://github.com/microsoft/vscode-js-debug/#nightly-extension) before they're in stable. Note that the minor version (`v1.X.0`) corresponds to the VS Code version js-debug is shipped in, but the patch version (`v1.50.X`) is not meaningful.
 
-## 1.99 (March 2025)
+## 1.100 (April 2025)
 
+- fix: explicitly specify completion ranges ([[vscode#243409](https://github.com/microsoft/vscode/issues/243409)])
 - fix: memory leak between debug sessions ([#2173](https://github.com/microsoft/vscode-js-debug/issues/2173))
 - fix: support `npm.scriptRunner: node`
 

src/adapter/completions.ts

@@ -217,6 +217,7 @@ export class Completions {
   ) {
     // Walk through the expression and look for any locally-declared variables or identifiers.
     const localIdentifiers: ICompletionWithSort[] = [];
+    const start = getStart(node);
     traverse(source, {
       enter(node) {
         const completion = inferCompletionInfoForDeclaration(node);
@@ -230,7 +231,7 @@ export class Completions {
       },
     });
 
-    const prefix = options.expression.slice(getStart(node), offset);
+    const prefix = options.expression.slice(start, offset);
     const completions = [
       ...localIdentifiers,
       ...(await this.defaultCompletions(options, prefix)),
@@ -248,6 +249,11 @@ export class Completions {
       });
     }
 
+    for (const completion of completions) {
+      completion.start = start;
+      completion.length = offset - start;
+    }
+
     return completions;
   }
 

src/test/completion/completion.test.ts

@@ -8,8 +8,22 @@ import { itIntegrates } from '../testIntegrationUtils';
 
 describe('completion', () => {
   const tcases: [string, Dap.CompletionItem[]][] = [
-    ['ar|', [{ label: 'arr', sortText: '~~arr', type: 'variable', detail: 'Array' }]],
-    ['ar|.length', [{ label: 'arr', sortText: '~~arr', type: 'variable', detail: 'Array' }]],
+    ['ar|', [{
+      label: 'arr',
+      sortText: '~~arr',
+      type: 'variable',
+      detail: 'Array',
+      start: 0,
+      length: 2,
+    }]],
+    ['ar|.length', [{
+      label: 'arr',
+      sortText: '~~arr',
+      type: 'variable',
+      detail: 'Array',
+      start: 0,
+      length: 2,
+    }]],
     [
       'arr.|',
       [
@@ -106,21 +120,51 @@ describe('completion', () => {
         },
       ],
     ],
-    ['ob|', [{ label: 'obj', sortText: '~~obj', type: 'variable', detail: 'Object' }]],
+    ['ob|', [{
+      label: 'obj',
+      sortText: '~~obj',
+      type: 'variable',
+      detail: 'Object',
+      start: 0,
+      length: 2,
+    }]],
     [
       'arr[myStr|',
-      [{ label: 'myString', sortText: '~~myString', type: 'variable', detail: 'string' }],
+      [{
+        label: 'myString',
+        sortText: '~~myString',
+        type: 'variable',
+        detail: 'string',
+        start: 4,
+        length: 5,
+      }],
     ],
     ['const replVar = 42; replV|', [{
       label: 'replVar',
       sortText: 'replVar',
       type: 'variable',
+      start: 20,
+      length: 5,
     }]],
     [
       'MyCoolCl|',
-      [{ label: 'MyCoolClass', sortText: '~~MyCoolClass', type: 'class', detail: 'fn()' }],
+      [{
+        label: 'MyCoolClass',
+        sortText: '~~MyCoolClass',
+        type: 'class',
+        detail: 'fn()',
+        start: 0,
+        length: 8,
+      }],
     ],
-    ['Strin|', [{ label: 'String', sortText: '~~String', type: 'class', detail: 'fn(?)' }]],
+    ['Strin|', [{
+      label: 'String',
+      sortText: '~~String',
+      type: 'class',
+      detail: 'fn(?)',
+      start: 0,
+      length: 5,
+    }]],
     [
       'myNeatFun|',
       [
@@ -129,6 +173,8 @@ describe('completion', () => {
           sortText: '~~myNeatFunction',
           type: 'function',
           detail: 'fn()',
+          start: 0,
+          length: 9,
         },
       ],
     ],
@@ -258,6 +304,8 @@ describe('completion', () => {
       {
         label: 'helloWorld',
         type: 'property',
+        start: 0,
+        length: 6,
       },
     ]);
   });