Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client agnostic support for the node-terminal adapter #2182

Open
igorlfs opened this issue Mar 9, 2025 · 0 comments
Open

Client agnostic support for the node-terminal adapter #2182

igorlfs opened this issue Mar 9, 2025 · 0 comments
Assignees
Labels
feature-request Request for new features or functionality

Comments

@igorlfs
Copy link

igorlfs commented Mar 9, 2025

Hello!

Is your feature request related to a problem? Please describe.

Currently, the node-terminal only works with VS Code (and derivatives), it cannot be used elsewhere. It would be nice to have a proper documentation on what needs to be implemented on the client side to have it working with other clients. Any guidance would be helpful.

In fact, I wonder if the protocol itself wouldn't benefit from having that logic to handle the terminal upstreamed. It would not only help with the implementation of this feature in other clients, but could offer a standardized way to interact with a terminal on the adapter side.

Describe the feature you'd like

Ideally, I believe this feature could be upstreamed to the DAP. If that's out of scope, is it possible to have a well-defined description of what (and potentially, how) to handle the node-terminal on the client side?

Additional context

Related: mfussenegger/nvim-dap#1033

@igorlfs igorlfs added the feature-request Request for new features or functionality label Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants