Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not write disableSmartSend to workspace settings #22541

Open
isidorn opened this issue Nov 28, 2023 · 1 comment
Open

Do not write disableSmartSend to workspace settings #22541

isidorn opened this issue Nov 28, 2023 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug needs community feedback Awaiting community feedback

Comments

@isidorn
Copy link

isidorn commented Nov 28, 2023

Testing #22536

  1. Follow steps from the test plan item
  2. Notice notification with the Disable Smart Send button.
  3. Click on the smart send button
  4. This setting is written in workspace settings 🐛

We should not use workspace settings for this, as this is a user preference. Writing to workspace settings enforces it on the whole team that uses that repository, and makes a dirty git change.

I suggest to instead use user settings. Or local storage.

@isidorn isidorn changed the title Do not write to workspace settings Do not write disableSmartSend to workspace settings Nov 28, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 28, 2023
@anthonykim1 anthonykim1 added needs community feedback Awaiting community feedback and removed triage-needed Needs assignment to the proper sub-team labels Nov 21, 2024
Copy link

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug needs community feedback Awaiting community feedback
Projects
None yet
Development

No branches or pull requests

3 participants