Not convinced about the disable smart send notification flow

[isidorn]

Testing #22536

Right now we show the notification to disable smart send.
Is there some better UI we could use - that is close to the actual error?

I also do not like that the only resolution for this is to Disable Smart Send. That sort of defeats the purpose of the feature.

[anthonykim1]

Hi @isidorn Thank you for your feedback! When you say better UI that is close to the actual error, do you mean possibly changing color of the "Disable Smart Send" button to red instead of blue?

Regarding resolution, it is tricky because Python standard library module AST which is behind the Smart Send logic refuses to parse a file with error, deprecated code entirely. This unable us to use smart send in parts of file where there is no error or deprecated code.

[isidorn]

Hi @anthonykim1

do you mean possibly changing color of the "Disable Smart Send" button to red instead of blue?

No. I meant some UI that is actually a part of the Smart Send flow. If such UI does not exist, should this maybe be a modal dialog? Similarly how errors before starting debugging are modal?

Also as an extension you can not control the color of the notification buttons (theme defines this).

[github-actions]

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.