Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Select warning UI when hitting shift + enter multiple times #22551

Closed
justschen opened this issue Nov 28, 2023 · 1 comment
Closed

Smart Select warning UI when hitting shift + enter multiple times #22551

justschen opened this issue Nov 28, 2023 · 1 comment
Assignees
Labels
info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team

Comments

@justschen
Copy link

Testing #22536

on linux, ubuntu 22

  1. shift + enter when notification is already up
  2. Pops up again.

When the warning is available, maybe it's better to just make it disappear?

Recording 2023-11-28 at 11 15 36

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 28, 2023
@anthonykim1
Copy link

This is expected behavior since if they are looking at this message, they are not able to shift+enter and execute their code. We want to let them know so they don't get confused of why shift+enter doesn't work all the sudden in case they come back after not reading and closing the warning message.

@anthonykim1 anthonykim1 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2023
@github-actions github-actions bot added the info-needed Issue requires more information from poster label Dec 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team
Projects
None yet
Development

No branches or pull requests

2 participants