Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should smart send apply to manual selections? #22557

Closed
mjbvz opened this issue Nov 28, 2023 · 3 comments
Closed

Should smart send apply to manual selections? #22557

mjbvz opened this issue Nov 28, 2023 · 3 comments
Assignees
Labels
area-repl info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team

Comments

@mjbvz
Copy link

mjbvz commented Nov 28, 2023

Testing #22536

If I manually select some code, it looks like smart send doesn't kick in. Is this expected?

My use case is that sometimes I want to run multiple lines of code. Right now I have to make the exact right selection or it doesn't work. I'd prefer just being able to select anywhere on the lines I want to run and hit shift+end

Example where I want it to work:

Image

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 28, 2023
@anthonykim1
Copy link

Hi Matt, thanks for the feedback. There has been a very long discussion and talk over this, but basically decided to not run smart send feature as user is being very explicit if they are willing to hand highlight the code they want to run. It was getting close to stepping out of bounds of what people want to do with their own code. Also for those who did not appreciate smart send in few scenarios, they have option to not use it by explicitly highlighting like this. It is designed over lots of arguments, thoughts, discussions.

@anthonykim1 anthonykim1 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2023
@github-actions github-actions bot added the info-needed Issue requires more information from poster label Nov 28, 2023
@mjbvz
Copy link
Author

mjbvz commented Nov 29, 2023

Maybe you can rename the setting to allow enabling this as a future option. I'd expect this feature to work more like vscode's expand selection

@github-actions github-actions bot removed the info-needed Issue requires more information from poster label Nov 29, 2023
@anthonykim1
Copy link

I'll look into what expand selection is and bring it up to the team! Thanks.

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Nov 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-repl info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team
Projects
None yet
Development

No branches or pull requests

2 participants