Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart send warning message feedback #22558

Open
mjbvz opened this issue Nov 28, 2023 · 7 comments
Open

Smart send warning message feedback #22558

mjbvz opened this issue Nov 28, 2023 · 7 comments
Assignees
Labels
area-repl feature-request Request for new features or functionality needs proposal Need to make some design decisions

Comments

@mjbvz
Copy link

mjbvz commented Nov 28, 2023

Testing #22536

Image

  • What is the code provided? I think it's the current file but it's not clear
  • What is smart send?
  • Should there be a button that tries running the code without using smart send?

Overall I find the warning difficult to understand. I think it would be clearer if it stated the following in in this order:

  • What happened at a high level (we couldn't run the selected code)
  • Why it happened (we couldn't parse the current file to determine what code to run)
  • How to fix the problem (either make a manual selection or disable smart send)
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 28, 2023
@movy
Copy link

movy commented Jun 7, 2024

Since this issue is #1 on google, I have exact same questions:

  • what is Smart send?
  • how to turn it off?

Looks like it invokes randomly, but has no traces in command palette or keyboard shortcuts.. and has a sneaky name also, like is my code sent somewhere based on some involuntarily invoked condition? So many questions without answers.

@anthonykim1
Copy link

Smart send is triggered via key binding shift+enter
You may find little description of it in the settings itself where you could also turn off the setting.
If you turn off the setting for smart send, every instance of shift+enter will send things to terminal exactly as you specify/highlight or just a single line if you shift enter on a blank line.
Screenshot 2024-06-07 at 3 50 00 PM

Feel free to turn off this setting in by easily clicking on your settings icon and then searching for 'smart send'

Screenshot 2024-06-07 at 3 47 58 PM

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Jun 7, 2024
@John-Polo
Copy link

tldr; I have tried on several occasions to find the documentation that matches the explanation provide by anthonykim1. Finally, I know how to activate/deactivate it.

I like the Smart Send. I have accidentally turned it off before. I could find nothing that explained how to change it's status. I just got the message referenced by OP, recognized it, and searched for it, and ended up here. This is the first time I have found anything approaching documentation that explains how to change it. I have looked all over stackoverflow for answers and tried different macros and other JSON settings and couldn't figure out how to turn it back on. Maybe because I couldn't remember the exact name of the feature after turning it off by accident, but the VS Code documentation could do a better job at addressing this feature.

Copy link

Hey @anthonykim1, this issue might need further attention.

@mjbvz, you can help us out by closing this issue if the problem no longer exists, or adding more information.

@anthonykim1
Copy link

anthonykim1 commented Jul 25, 2024

@John-Polo Thanks for feedback here. I would bring this up to the team so we can provide better documentation on smart send.

Coming back to this sort of message/warning for sending commands to REPL (both terminal and native REPL), wondering what people think about the way Julia extension is handling things. When you shift+enter on a julia file, it sort of blinks and shows little hint on what is being sent to the REPL as well as the colorization depending on the success/failure output.
Screenshot 2024-07-25 at 12 03 49 PM

@anthonykim1 anthonykim1 added feature-request Request for new features or functionality and removed triage-needed Needs assignment to the proper sub-team labels Jul 25, 2024
Copy link

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on, then we will be happy to re-open this issue to pick up where we left off.

Happy Coding!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2024
@anthonykim1
Copy link

Reopening this since this is fair/valid.

@anthonykim1 anthonykim1 reopened this Aug 26, 2024
@anthonykim1 anthonykim1 removed the info-needed Issue requires more information from poster label Aug 26, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Aug 26, 2024
@anthonykim1 anthonykim1 added needs proposal Need to make some design decisions and removed triage-needed Needs assignment to the proper sub-team labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl feature-request Request for new features or functionality needs proposal Need to make some design decisions
Projects
None yet
Development

No branches or pull requests

4 participants