Terminal does not pick up new shell integration

[aeschli]

Testing #24747

Version: 1.97.0-insider
Commit: 3250a26dfecc06defce495f1e16b80681974c62b
Date: 2025-01-29T05:04:50.952Z
Electron: 32.2.7
ElectronBuildId: 10660205
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Linux x64 5.15.0-130-generic

There's something fishy about the activation of shell integration. For the longest time I didn't see the Python shell integration as described in #24747.

Then suddenly it appeared, for no apparent reason.

Here is some observation

• run VS Code with a new profile
• set "python.terminal.shellIntegration.enabled": true,
• open a terminal and hover over the `bash' terminal. You can see that there's one shell integration 'git'
• install python (prerelease), this should add two more shell integration
• right after installing, the terminal does not show anything
• open a python file, now they are added
  -> looks like the python extension needs an activation point so that it is activated on startup and can contribute the integration?

---

• set "python.terminal.shellIntegration.enabled": false,
• the terminal keep showing the 'Python; shell integration
• reloading window, killing terminal doesn't help, 'Python`; keeps showing
• uninstalling and installing the extension helps

---

• set "python.terminal.shellIntegration.enabled": true,
• uninstall python, install python and opening a python file is needed

[anthonykim1]

HI @aeschli Thanks for testing my TPI.

I think changing the value/setting the value to `"python.terminal.shellIntegration.enabled": true needs to be paired with reloading in order for this setting to be effective atm (also Python ext needs to be activated)

In order for to set shell integration for Python specifically (and run all these code that show you the link to Native REPL, etc), we have to reload after setting the setting value.

And also create a new terminal (be wary of those with yellow warning sign in terminal, it would mean you should create a new terminal for changes to be effective).

And yes you are totally correct that Python extension needs to be activated before anything happens, because the script with these functionality comes from Python extension side of things.

#24373 should resolve lots of "fishy" behaviors that comes with reloading stuff.

[anthonykim1]

reloading window, killing terminal doesn't help, 'Python`; keeps showing

This should actually be fine, since it just adds more visibility to Native REPL. I honestly want to make it show up without the shell integration setting at some point as well.

I'll close this against #24373 since I assume solving #24373 would resolve these fishy behaviors.