Skip to content

ensureTerminal should return Promise<Terminal> #24106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
anthonykim1 opened this issue Sep 12, 2024 · 0 comments · May be fixed by #24942
Open

ensureTerminal should return Promise<Terminal> #24106

anthonykim1 opened this issue Sep 12, 2024 · 0 comments · May be fixed by #24942
Assignees
@anthonykim1
Labels
area-terminal debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on

Comments

@anthonykim1
Copy link

ensureTerminal should return Promise rather than Promise.
This way we dont have to have the TerminalService class save the state of Terminal.

Could even potentially look at getting rid of TerminalService.
@anthonykim1 anthonykim1 added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-terminal labels Sep 12, 2024
@anthonykim1 anthonykim1 self-assigned this Sep 12, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 12, 2024
@anthonykim1 anthonykim1 mentioned this issue Sep 12, 2024
Merged
@anthonykim1 anthonykim1 added needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Dec 3, 2024
@karthiknadig karthiknadig linked a pull request Mar 29, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonykim1 anthonykim1

Labels
area-terminal debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: refactor ensureTerminal to return a Terminal karthiknadig/vscode-python
1 participant
@anthonykim1